-
Notifications
You must be signed in to change notification settings - Fork 4
RDKEMW-10671 : Intermittent failure on Testframework while running entservices-softwareupdate workflows. #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smanes0213
wants to merge
43
commits into
develop
Choose a base branch
from
Test_Workflow
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
6791519
Update L2-tests.yml
balav08 1bdf523
Update MaintenancemanagerL2.cpp
balav08 0be910e
Update MaintenancemanagerL2.cpp
balav08 f8879c1
Merge pull request #174 from rdkcentral/develop
balav08 2bcf266
Update L2-tests.yml
balav08 e3edcf5
Update L1-tests.yml
balav08 5d132ec
Update L2-tests.yml
balav08 07a8abe
Update L1-tests.yml
balav08 f4055f7
Update L2-tests.yml
balav08 0eebe13
Update L1-tests.yml
balav08 be6f202
Update L2-tests.yml
balav08 6ecaba7
Merge pull request #176 from rdkcentral/develop
balav08 9ad1c4f
Decrease sleep time in maintenance tests
balav08 cbcbea5
Simplify L2 test workflow by removing GDB logging
balav08 5f3705f
Merge pull request #178 from rdkcentral/develop
balav08 602b13b
Merge pull request #181 from rdkcentral/develop
balav08 0e96778
Update MaintenancemanagerL2.cpp
balav08 9e84a5b
Update MaintenancemanagerL2.cpp
balav08 49816a6
Update MaintenancemanagerL2.cpp
balav08 ef620b4
Update MaintenancemanagerL2.cpp
balav08 0ab5043
Merge branch 'feature/L1-L2test' of https://github.com/rdkcentral/ent…
balaji-86 3e2e761
Merge branch 'feature/L1-L2test' of https://github.com/rdkcentral/ent…
balaji-86 a25fad1
Merge branch 'feature/L1-L2test' of https://github.com/rdkcentral/ent…
balaji-86 d2e053a
Update MaintenancemanagerL2.cpp
balav08 f3ab9f0
Update L2-tests.yml
smanes0213 bc6bd6d
Improve MaintainanceManager L2 test
smanes0213 42445b6
Add conditional check for tests running with valgrind and coverage ge…
smanes0213 dd99d80
Update L1-tests.yml
smanes0213 8d950bb
Update Tests/L2Tests/tests/MaintenancemanagerL2.cpp
smanes0213 af0885d
Update Tests/L2Tests/tests/MaintenancemanagerL2.cpp
smanes0213 109bc11
Update L2-tests.yml
smanes0213 c0691a9
Update L1-tests.yml
smanes0213 040a9f7
Update MaintenancemanagerL2.cpp
smanes0213 fef3471
Fix L1 cache collision: Add repository-specific cache key
smanes0213 1cd62a5
Fix L1 cache paths to match actual build output locations
smanes0213 f718e57
Add cache-hit condition to patch steps to prevent errors when cache i…
smanes0213 e4ec051
Remove cache-hit condition from entservices-apis checkout - needed on…
smanes0213 dc6cd16
Remove cache-hit conditions from googletest - excluded from cache so …
smanes0213 a26c49f
Always checkout Thunder source - headers needed for builds even when …
smanes0213 79adedb
Remove Thunder source includes from builds - use only installed heade…
smanes0213 764fc22
Always checkout Thunder source and add includes for testframework bui…
smanes0213 5f5b920
Remove duplicate Thunder source includes from component build, keep o…
smanes0213 2763b66
Merge branch 'develop' into Test_Workflow
smanes0213 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -118,22 +118,25 @@ TEST_F(MaintenanceManagerTest, getMaintenanceStartTime_json_rpc) | |
| MaintenanceManagerConfFile << "start_min=\"30\"\n"; | ||
| MaintenanceManagerConfFile << "tz_mode=\"UTC\"\n"; | ||
| MaintenanceManagerConfFile.close(); | ||
| std::ifstream MaintenanceManagerConfFile("/opt/rdk_maintenance.conf"); | ||
| if (!MaintenanceManagerConfFile) { | ||
| std::cerr << "Failed to open /opt/rdk_maintenance.conf for reading." << std::endl; | ||
| } | ||
|
|
||
| } | ||
|
|
||
| std::ifstream verifyFile("/opt/rdk_maintenance.conf"); | ||
| if (!verifyFile) { | ||
| std::cerr << "Failed to open /opt/rdk_maintenance.conf for reading." << std::endl; | ||
| } else { | ||
| std::string line; | ||
| while (std::getline(MaintenanceManagerConfFile, line)) { | ||
| while (std::getline(verifyFile, line)) { | ||
| std::cout << line << std::endl; | ||
| } | ||
| verifyFile.close(); | ||
| } | ||
|
Comment on lines
+123
to
+132
|
||
|
|
||
| status = InvokeServiceMethod("org.rdk.MaintenanceManager", "getMaintenanceStartTime", params1, results1); | ||
| ASSERT_EQ(results1["success"].Boolean(), true); | ||
| ASSERT_EQ(status, Core::ERROR_NONE); | ||
| } | ||
|
|
||
|
|
||
| } | ||
|
|
||
| //getMaintenanceActivityStatus jsonRPC | ||
| TEST_F(MaintenanceManagerTest,getMaintenanceActivityStatus) | ||
| { | ||
|
|
@@ -163,9 +166,30 @@ TEST_F(MaintenanceManagerTest,stopMaintenance) | |
| { | ||
| uint32_t status = Core::ERROR_GENERAL; | ||
| JsonObject params1, results1; | ||
| bool maintenanceStarted = false; | ||
|
|
||
| // Wait for maintenance to actually start (with timeout) | ||
| int retries = 10; // 10 seconds max | ||
| while (retries-- > 0) { | ||
| status = InvokeServiceMethod("org.rdk.MaintenanceManager","getMaintenanceActivityStatus",params1, results1); | ||
| if ((status == Core::ERROR_NONE) && | ||
| results1.HasLabel("maintenanceStatus") && | ||
| results1["maintenanceStatus"].String() == "MAINTENANCE_STARTED") { | ||
| maintenanceStarted = true; | ||
| break; | ||
| } | ||
| sleep(1); | ||
| } | ||
|
|
||
| // Verify maintenance is running | ||
| ASSERT_TRUE(maintenanceStarted) | ||
| << "Maintenance did not start within timeout. Last status: " | ||
| << results1["maintenanceStatus"].String(); | ||
|
|
||
| // Now stop the active maintenance | ||
| status = InvokeServiceMethod("org.rdk.MaintenanceManager","stopMaintenance",params1, results1); | ||
| ASSERT_EQ(results1["success"].Boolean(), true); | ||
| ASSERT_EQ(status, Core::ERROR_NONE); | ||
| ASSERT_EQ(results1["success"].Boolean(), true); | ||
| } | ||
|
|
||
| //startMaintenance jsonPRC Test on an active Maintenance Cycle | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow is being changed to use a test branch 'Test_Workflow' instead of 'develop'. This appears to be a temporary change for testing purposes and should likely not be merged to the main branch. Using a test branch reference in the workflow configuration could cause CI/CD failures once the test branch is removed or if the branch doesn't exist in production environments.