fix D555 error with -r parameter on rs-fw-update #14405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes a D555 error that occurs when using the -r parameter on rs-fw-update by refactoring firmware compatibility checking and device detection logic.
- Extracted firmware compatibility checking into a reusable
is_fw_compatiblefunction - Modified device detection logic to identify recovery mode devices by checking sensor count instead of using
is<update_device>() - Removed redundant custom file deleters in favor of RAII automatic cleanup
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nir-Az
reviewed
Nov 2, 2025
Nir-Az
reviewed
Nov 2, 2025
Nir-Az
reviewed
Nov 2, 2025
Nir-Az
reviewed
Nov 2, 2025
Nir-Az
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked on: [RSDSO-20616]