add D555 to test-fw-update #14428

AviaAv · 2025-11-10T07:58:24Z

Tracked on: [LRS-1349]

Copilot

Pull Request Overview

This PR adds support for D555 devices to the firmware update test. The changes enable testing firmware updates for D555 devices alongside the existing D400 device support, including handling device-specific differences like the absence of an update counter in D555.

Key changes:

Added D555 device support with a dedicated command-line argument for custom D555 firmware
Refactored firmware selection logic to handle both D400 and D555 devices
Updated device detection to use serial numbers for tracking devices through the update process

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
unit-tests/test-fw-update.py	Added D555 device support, refactored firmware path handling, improved device tracking with serial numbers, and added D555-specific logic for update counter
unit-tests/run-unit-tests.py	Added command-line argument support for custom D555 firmware path

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

unit-tests/test-fw-update.py

OhadMeir · 2025-11-10T15:28:36Z

unit-tests/run-unit-tests.py

    print( '        --no-reset           Do not try to reset any devices, with or without a hub' )
    print( '        --hub-reset          If a hub is available, reset the hub itself' )
    print( '        --custom-fw-d400          If custom fw provided flash it if its different that the current fw installed' )
+    print( '        --custom-fw-d555          If custom fw provided flash it if its different that the current fw installed' )


Seems relevant to all D500

@OhadMeir we cannot use it for D500 as D555 and D585 does not share the same FW image.
Need to revert back to D555 only.
When D585 be added we will add another field for it

I was under the impression that with D585 new FW update process uses a single file similar to the D555.
Can't the same procedure be used for both?

run-unit-tests.py is called once for all cameras, same flow should work on D555 and D585, but the input file is different, so we need 2 parameters.
Does this answer?
If not lets talk :)

As discussed, leave D555

Reverted changes

OhadMeir · 2025-11-10T15:30:10Z

unit-tests/test-fw-update.py


    if product_line == "D400":
        size = 0x2
+    elif "D555" in product_name:


Same, check D500 product line, not D555 specific

That's OK to keep as all D500 does not have a counter

Co-authored-by: Copilot <[email protected]>

unit-tests/test-fw-update.py

Nir-Az · 2025-11-12T15:28:44Z

unit-tests/run-unit-tests.py

    print( '        --no-reset           Do not try to reset any devices, with or without a hub' )
    print( '        --hub-reset          If a hub is available, reset the hub itself' )
    print( '        --custom-fw-d400          If custom fw provided flash it if its different that the current fw installed' )
+    print( '        --custom-fw-d500          If custom fw provided flash it if its different that the current fw installed' )


Nir-Az · 2025-11-12T15:28:51Z

unit-tests/run-unit-tests.py

                                longopts=['help', 'verbose', 'debug', 'quiet', 'regex=', 'stdout', 'tag=', 'list-tags',
                                          'list-tests', 'no-exceptions', 'context=', 'repeat=', 'retry=', 'config=', 'no-reset', 'hub-reset',
-                                          'rslog', 'skip-disconnected', 'live', 'not-live', 'device=', 'exclude-device=', 'test-dir=','skip-regex=','custom-fw-d400='] )
+                                          'rslog', 'skip-disconnected', 'live', 'not-live', 'device=', 'exclude-device=', 'test-dir=','skip-regex=','custom-fw-d400=','custom-fw-d500='] )


Nir-Az · 2025-11-12T15:29:17Z

unit-tests/test-fw-update.py

 parser = argparse.ArgumentParser(description="Test firmware update")
-parser.add_argument('--custom-fw-d400', type=str, help='Path to custom firmware file')
+parser.add_argument('--custom-fw-d400', type=str, help='Path to custom D400 firmware file')
+parser.add_argument('--custom-fw-d500', type=str, help='Path to custom D500 firmware file')


Nir-Az · 2025-11-12T15:30:12Z

unit-tests/test-fw-update.py

+custom_fw_version = None
+if product_line == "D400" and args.custom_fw_d400:
+    custom_fw_path = args.custom_fw_d400
+elif product_line == "D500" and args.custom_fw_d500:


camera_name include D555

Nir-Az · 2025-11-12T15:30:32Z

unit-tests/test-fw-update.py

-        image_file = find_image_or_exit(product_name)
+        # always flash signed fw when device on recovery before flashing anything else
+        # on D500 we currently do not have bundled FW
+        image_file = find_image_or_exit(product_name) if not product_line == "D500" else custom_fw_path


d555 all over

All reverted

..

Nir-Az · 2025-11-13T15:41:32Z

@AviaAv please avoid doing commit --amend during a CR as now we cannot see the new changed and need to review all changes again..

AviaAv requested review from Nir-Az and Copilot November 10, 2025 07:58

Copilot AI reviewed Nov 10, 2025

View reviewed changes

unit-tests/test-fw-update.py Show resolved Hide resolved

unit-tests/test-fw-update.py Outdated Show resolved Hide resolved

unit-tests/test-fw-update.py Outdated Show resolved Hide resolved

AviaAv force-pushed the tests-2 branch from bba89ea to 3e91edb Compare November 10, 2025 08:15

Nir-Az reviewed Nov 10, 2025

View reviewed changes

unit-tests/test-fw-update.py Outdated Show resolved Hide resolved

Nir-Az reviewed Nov 10, 2025

View reviewed changes

unit-tests/test-fw-update.py Show resolved Hide resolved

Nir-Az reviewed Nov 10, 2025

View reviewed changes

unit-tests/test-fw-update.py Show resolved Hide resolved

OhadMeir reviewed Nov 10, 2025

View reviewed changes

AviaAv and others added 2 commits November 11, 2025 15:58

add D555 to test-fw-update

00fca79

Fix typo

9ccd332

Co-authored-by: Copilot <[email protected]>

AviaAv force-pushed the tests-2 branch from bc9a2b1 to 50c1f87 Compare November 11, 2025 13:59

AviaAv commented Nov 11, 2025

View reviewed changes

unit-tests/test-fw-update.py Show resolved Hide resolved

AviaAv requested review from Nir-Az and OhadMeir November 12, 2025 13:30

Nir-Az reviewed Nov 12, 2025

View reviewed changes

fix recovery issues

77bbceb

..

AviaAv force-pushed the tests-2 branch from 50c1f87 to 77bbceb Compare November 13, 2025 15:37

AviaAv requested a review from Nir-Az November 13, 2025 15:38

Nir-Az approved these changes Nov 17, 2025

View reviewed changes

Nir-Az merged commit e5faf0b into realsenseai:development Nov 17, 2025
26 checks passed

add D555 to test-fw-update #14428

add D555 to test-fw-update #14428

Conversation

AviaAv commented Nov 10, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Nir-Az commented Nov 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants