adding d401_gmsl device is SDK and linux backend #14445
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the D401 GMSL device across the SDK and Linux backend. The changes introduce a new product ID (0xABCC) and integrate it throughout the device initialization, identification, and configuration pipeline.
Key changes:
- Added D401_GMSL_PID constant (0xABCC) and corresponding device class implementation
- Integrated D401 GMSL into device detection and initialization logic
- Configured device-specific settings including firmware version requirements and stream profiles
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/linux/backend-v4l2.h | Defines D401_GMSL_PID constant for V4L2 backend |
| src/linux/backend-v4l2.cpp | Adds D401 GMSL device identification logic and MIPI device detection |
| src/ds/d400/d400-private.h | Registers D401 GMSL in device lists, naming map, and firmware requirements |
| src/ds/d400/d400-nonmonochrome.cpp | Excludes D401 GMSL from auto white balance feature |
| src/ds/d400/d400-factory.cpp | Implements rs401_gmsl_device class and factory instantiation |
| src/ds/d400/d400-device.cpp | Adds D401 GMSL to MIPI device checks for timestamp reader selection |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/ds/d400/d400-private.h
Outdated
| {RS430_GMSL_PID, "5.16.8.0" }, | ||
| {RS415_GMSL_PID, "5.17.1.1" } | ||
| {RS415_GMSL_PID, "5.17.1.1" }, | ||
| {RS401_GMSL_PID, "5.17.2.100" } |
There was a problem hiding this comment.
This is the one I had now, that supported the device for now.
I ll update it when I get other info.
remibettan
force-pushed
the
adding_d401_gmsl
branch
from
f8bce55 to
7ae658e
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| {RS430_GMSL_PID, "5.16.8.0" }, | ||
| {RS415_GMSL_PID, "5.17.1.1" } | ||
| {RS415_GMSL_PID, "5.17.1.1" }, | ||
| {RS401_GMSL_PID, "5.17.2.100" } // TO BE UPDATED!!! |
There was a problem hiding this comment.
The comment 'TO BE UPDATED!!!' indicates that the firmware version for RS401_GMSL_PID is a placeholder. This should be updated with the correct minimum firmware version before merging, or a tracking issue should be created.
| {RS401_GMSL_PID, "5.17.2.100" } // TO BE UPDATED!!! | |
| {RS401_GMSL_PID, "5.17.3.0" } |
2 participants
Tracked by: RSDSO-20657