Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-viewer: firmware update proposal + one-click update #15391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
react-viewer: firmware update proposal + one-click update #15391
Changes from all commits
d0ec87f7f7d8f8File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [rs-agentic] BUG — empty DB cached permanently
If the server returns a well-formed JSON with an empty
versionsarray (e.g. CDN hiccup, wrong endpoint),entries = []is stored here. Because the guard above checksis not None, an empty list passes it and will be returned forever — silently suppressing all firmware proposals for the process lifetime.Consider only caching when
entriesis non-empty:Or distinguish between "not yet fetched" and "fetched empty" with an explicit sentinel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potential user input in HTTP request may allow SSRF attack - low severity
If an attacker can control the URL input leading into this HTTP request, the attack might be able to perform an SSRF attack. This kind of attack is even more dangerous if the application returns the response of the request to the user. It could allow them to retrieve information from higher privileged services within the network (such as the metadata service, which is commonly available in cloud services, and could allow them to retrieve credentials).
Show fix
Remediation: If possible, only allow requests to allowlisting domains. If not, consult the article linked above to learn about other mitigating techniques such as disabling redirects, blocking private IPs and making sure private services have internal authentication. If you return data coming from the request to the user, validate the data before returning it to make sure you don't return random data.
Reply
@AikidoSec ignore: [REASON]to ignore this issue.More info
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 [rs-agentic] Minor —
on_progress(1.0)called twiceWhen
Content-Lengthis known and the last chunk fills the buffer exactly,on_progress(min(len(buf)/total, 1.0))inside the loop already fires1.0. The unconditional call here emits it again. Rate-limiting in_make_fw_progress_callbackletsp == 1.0through unconditionally, so two100%events are emitted. Harmless but noisy on the socket.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.