D555 emitter on/off support over USB#15445
Open
AviaAv wants to merge 2 commits into
Open
Conversation
AviaAv
force-pushed
the
rsdev-9415-d555-emitter-onoff
branch
2 times, most recently
from
July 20, 2026 08:37
e00331d to
a90cf4c
Compare
AviaAv
force-pushed
the
rsdev-9415-d555-emitter-onoff
branch
from
July 20, 2026 10:05
a90cf4c to
f9ece5a
Compare
sysrsbuild-gh-agentic
left a comment
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Auto-generated review by rs-agentic bot
Reviewed new commit f9ece5a — BUG-focused per push-review policy.
AviaAv
force-pushed
the
rsdev-9415-d555-emitter-onoff
branch
from
July 20, 2026 10:14
f9ece5a to
728f575
Compare
AviaAv
force-pushed
the
rsdev-9415-d555-emitter-onoff
branch
from
July 20, 2026 11:46
728f575 to
ae50057
Compare
Nir-Az
reviewed
Jul 21, 2026
Nir-Az
reviewed
Jul 22, 2026
| auto emitter_always_on_opt = std::make_shared<emitter_always_on_option>( _hw_monitor, emitter_get_opcode, emitter_set_opcode ); | ||
| get_depth_sensor().register_option( RS2_OPTION_EMITTER_ALWAYS_ON, emitter_always_on_opt ); | ||
|
|
||
| if( get_pid() == D555_PID ) |
Collaborator
There was a problem hiding this comment.
Dont we need to gate a specific FW version that from that version it is supported?
AviaAv
force-pushed
the
rsdev-9415-d555-emitter-onoff
branch
from
July 22, 2026 07:34
08743ea to
e52f238
Compare
Nir-Az
reviewed
Jul 23, 2026
| { | ||
| int on_off = value > 0 ? 1 : 0; | ||
| // AUTO_CALIB doubles as the HKR custom-command carrier; param1 selects the sub-command. | ||
| command cmd( ds::AUTO_CALIB, ds_calib_common::SET_EMITTER_ON_OFF, on_off ); |
Collaborator
There was a problem hiding this comment.
As discussed, auto_calib looks like a WA, lets do it with proper naming
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on: [RSDEV-9415]