Skip to content

turn the FATAL_ERROR for ROS distro check into a WARNING #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christian-rauch wants to merge 3 commits into
base: ros2-master
Choose a base branch
from
Open

turn the FATAL_ERROR for ROS distro check into a WARNING #3550

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e51892
turn the FATAL_ERROR for ROS distro check into a WARNING
christian-rauch Aug 17, 2026
6fcba2f
always add 'ros_param_backend.cpp' to the sources
christian-rauch Aug 17, 2026
3871f50
remove trailing whitespace
christian-rauch Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions realsense2_camera/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ set(SOURCES
src/tfs.cpp
src/actions.cpp
src/safety.cpp
src/ros_param_backend.cpp
)

if (BUILD_ACCELERATE_GPU_WITH_GLSL)
Expand All @@ -196,29 +197,23 @@ endif()
if("$ENV{ROS_DISTRO}" STREQUAL "foxy")
message(STATUS "Build for ROS2 Foxy")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DFOXY")
set(SOURCES "${SOURCES}" src/ros_param_backend.cpp)
elseif("$ENV{ROS_DISTRO}" STREQUAL "humble")
message(STATUS "Build for ROS2 Humble")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DHUMBLE")
set(SOURCES "${SOURCES}" src/ros_param_backend.cpp)
elseif("$ENV{ROS_DISTRO}" STREQUAL "iron")
message(STATUS "Build for ROS2 Iron")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DIRON")
set(SOURCES "${SOURCES}" src/ros_param_backend.cpp)
elseif("$ENV{ROS_DISTRO}" STREQUAL "rolling")
message(STATUS "Build for ROS2 Rolling")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DROLLING")
set(SOURCES "${SOURCES}" src/ros_param_backend.cpp)
elseif("$ENV{ROS_DISTRO}" STREQUAL "jazzy")
message(STATUS "Build for ROS2 Jazzy")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DJAZZY")
set(SOURCES "${SOURCES}" src/ros_param_backend.cpp)
elseif("$ENV{ROS_DISTRO}" STREQUAL "kilted")
message(STATUS "Build for ROS2 Kilted")
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DKILTED")
set(SOURCES "${SOURCES}" src/ros_param_backend.cpp)
else()
message(FATAL_ERROR "Unsupported ROS Distribution: " "$ENV{ROS_DISTRO}")
message(WARNING "Unsupported ROS Distribution: " "$ENV{ROS_DISTRO}")
endif()
Comment thread
christian-rauch marked this conversation as resolved.

# The header 'cv_bridge/cv_bridge.hpp' was added in version 3.3.0. For older
Expand Down Expand Up @@ -326,7 +321,7 @@ if(USE_LIFECYCLE_NODE)
find_package(rclcpp_lifecycle REQUIRED)
find_package(lifecycle_msgs REQUIRED)
list(APPEND dependencies rclcpp_lifecycle lifecycle_msgs)
list(APPEND targets
list(APPEND targets
rclcpp_lifecycle::rclcpp_lifecycle
lifecycle_msgs::lifecycle_msgs__rosidl_typesupport_cpp)
add_definitions(-DUSE_LIFECYCLE_NODE)
Expand Down Expand Up @@ -375,13 +370,13 @@ install(
)

# Install launch files
install(DIRECTORY
install(DIRECTORY
launch
DESTINATION share/${PROJECT_NAME}
)

# Install example files
install(DIRECTORY
install(DIRECTORY
examples
DESTINATION share/${PROJECT_NAME}
)
Expand Down
Loading