Update setup_workspace.sh - #314
Closed
ymodlin wants to merge 8 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR comments out the call to DisplayNvidiaLicense in the workspace setup script, effectively disabling the display of the NVIDIA license during setup.
Key Changes
- Disabled NVIDIA license display by commenting out the
DisplayNvidiaLicensefunction call
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -43,7 +43,7 @@ export DEVDIR=$(cd `dirname $0` && pwd) | |||
| echo "Setup JetPack $1 to sources_$JETPACK_VERSION" | |||
|
|
|||
| # Display NVIDIA license | |||
There was a problem hiding this comment.
The DisplayNvidiaLicense call has been commented out without explanation. If this is intentional (e.g., license display is no longer required), consider adding a comment explaining why this was disabled. If the function or its dependencies are being removed, consider removing this line entirely rather than leaving it commented.
Suggested change
| # Display NVIDIA license | |
| # Display NVIDIA license | |
| # The DisplayNvidiaLicense call is intentionally disabled. License display is no longer required for this script. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.