Update workflow to include artifacts uploads. - #315
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions workflow to include artifact uploads for the JP6 build process. The changes enable preservation and sharing of build outputs from the JetPack 6.0 build pipeline.
Key Changes:
- Added artifact creation step that packages nvidia-oot modules, kernel HID modules, and rootfs into compressed archives
- Configured upload actions for six different artifact types (modules, kernel components, and device tree files) with 30-day retention
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| JETPACK_VER="6.0" | ||
| KERNEL_VERSION="5.15.136-tegra" |
There was a problem hiding this comment.
The hardcoded version values '6.0' and '5.15.136-tegra' create duplication with the '6.0' parameter passed to build scripts in line 25. Consider extracting these as workflow-level environment variables or job outputs to maintain consistency and avoid version mismatches.
| tar -czf "./images/${JETPACK_VER}/nvidia-oot-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/updates" | ||
|
|
||
| # Create kernel HID modules archive | ||
| echo "Creating kernel HID modules archive" | ||
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/extra" |
There was a problem hiding this comment.
The tar command uses a relative path for the archive target './lib/modules/${KERNEL_VERSION}/updates' which may not work as intended. When using '-C' to change directory, the path should be relative to that new directory. This should likely be 'lib/modules/${KERNEL_VERSION}/updates' without the leading './'.
| tar -czf "./images/${JETPACK_VER}/nvidia-oot-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/updates" | |
| # Create kernel HID modules archive | |
| echo "Creating kernel HID modules archive" | |
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/extra" | |
| tar -czf "./images/${JETPACK_VER}/nvidia-oot-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "lib/modules/${KERNEL_VERSION}/updates" | |
| # Create kernel HID modules archive | |
| echo "Creating kernel HID modules archive" | |
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "lib/modules/${KERNEL_VERSION}/extra" |
|
|
||
| # Create kernel HID modules archive | ||
| echo "Creating kernel HID modules archive" | ||
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/extra" |
There was a problem hiding this comment.
The tar command uses a relative path for the archive target './lib/modules/${KERNEL_VERSION}/extra' which may not work as intended. When using '-C' to change directory, the path should be relative to that new directory. This should likely be 'lib/modules/${KERNEL_VERSION}/extra' without the leading './'.
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/extra" | |
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "lib/modules/${KERNEL_VERSION}/extra" |
No description provided.