-
Notifications
You must be signed in to change notification settings - Fork 30
Update workflow to include artifacts uploads. #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
caa46b7
Update workflow to include artifacts uploads.
ymodlin 60bcbfb
Add a release workflow
ymodlin c158e24
Add copilot instructions
ymodlin 35c58c7
add documenting instructions
ymodlin df59711
Upload fixed yaml file for JP6.1 & JP6.2
ymodlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -23,3 +23,64 @@ jobs: | |||||||||||||||||||||||||
| run: git config --global user.email "builder@example.com" && git config --global user.name "builder" && ./apply_patches.sh 6.0 | ||||||||||||||||||||||||||
| - name: build | ||||||||||||||||||||||||||
| run: ./build_all.sh 6.0 | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| - name: Create artifact archives | ||||||||||||||||||||||||||
| run: | | ||||||||||||||||||||||||||
| JETPACK_VER="6.0" | ||||||||||||||||||||||||||
| KERNEL_VERSION="5.15.136-tegra" | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Create nvidia-oot modules archive | ||||||||||||||||||||||||||
| echo "Creating nvidia-oot modules archive" | ||||||||||||||||||||||||||
| tar -czf "./images/${JETPACK_VER}/nvidia-oot-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/updates" | ||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||
| # Create kernel HID modules archive | ||||||||||||||||||||||||||
| echo "Creating kernel HID modules archive" | ||||||||||||||||||||||||||
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/extra" | ||||||||||||||||||||||||||
|
Comment on lines
+34
to
+38
|
||||||||||||||||||||||||||
| tar -czf "./images/${JETPACK_VER}/nvidia-oot-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/updates" | |
| # Create kernel HID modules archive | |
| echo "Creating kernel HID modules archive" | |
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/extra" | |
| tar -czf "./images/${JETPACK_VER}/nvidia-oot-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "lib/modules/${KERNEL_VERSION}/updates" | |
| # Create kernel HID modules archive | |
| echo "Creating kernel HID modules archive" | |
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "lib/modules/${KERNEL_VERSION}/extra" |
Copilot
AI
Dec 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tar command uses a relative path for the archive target './lib/modules/${KERNEL_VERSION}/extra' which may not work as intended. When using '-C' to change directory, the path should be relative to that new directory. This should likely be 'lib/modules/${KERNEL_VERSION}/extra' without the leading './'.
Suggested change
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "./lib/modules/${KERNEL_VERSION}/extra" | |
| tar -czf "./images/${JETPACK_VER}/kernel-hid-modules.tar.gz" -C "./images/${JETPACK_VER}/rootfs/" "lib/modules/${KERNEL_VERSION}/extra" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded version values '6.0' and '5.15.136-tegra' create duplication with the '6.0' parameter passed to build scripts in line 25. Consider extracting these as workflow-level environment variables or job outputs to maintain consistency and avoid version mismatches.