Update README links: migrate to realsenseai GitHub and store - #351
Update README links: migrate to realsenseai GitHub and store#351sareluzi wants to merge 6 commits into
Conversation
* Fix readme file to remove Intel * Update Security.md
…IT over SSH priority (#346)
…347) Tracked-on RSDSO 21089: Device did not reset after executing the hardware reset script
…er directory removal before linking
- Update GitHub repo URLs from IntelRealSense to realsenseai - Update store URLs from store.intelrealsense.com to store.realsenseai.com - Remove "Intel®" branding from titles and descriptions - Replace broken DES457 store links with text-only mentions Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/buffer/kfifo_buf.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/buffer/industrialio-triggered-buffer.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/common/hid-sensors/hid-sensor-iio-common.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/hid/hid-sensor-hub.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/accel/hid-sensor-accel-3d.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/gyro/hid-sensor-gyro-3d.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/common/hid-sensors/hid-sensor-trigger.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| # RealSense cameras support | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/usb/uvc/uvcvideo.ko $KERNEL_MODULES_OUT/extra/ | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/v4l2-core/videodev.ko $KERNEL_MODULES_OUT/extra/ | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/usb/uvc/uvcvideo.ko $KERNEL_MODULES_OUT/extra/ || true | ||
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/v4l2-core/videodev.ko $KERNEL_MODULES_OUT/extra/ || true |
There was a problem hiding this comment.
Added 'cp ... || true' to kernel module copy operations which suppresses failures; remove '|| true' so the script fails visibly (or handle missing files explicitly).
Details
✨ AI Reasoning
apply the change intent check: the PR added '|| true' to kernel module cp invocations, which disables the script's failure behavior (set -e). This masks missing files or copy errors and turns hard failures into silent successes, making errors harder to detect and recover from. Fixing restores fail-fast behavior.
🔧 How do I fix it?
Remove debugging statements like console.log, debugger, dd(), or logic bypasses like || true. Keep legitimate logging for monitoring and error handling.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Show Fix
Remediation - low confidence
This patch mitigates temporary bypass artifacts by removing '|| true' from kernel module copy operations to restore fail-fast behavior under 'set -e'.
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/buffer/kfifo_buf.ko $KERNEL_MODULES_OUT/extra/ || true | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/buffer/industrialio-triggered-buffer.ko $KERNEL_MODULES_OUT/extra/ || true | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/common/hid-sensors/hid-sensor-iio-common.ko $KERNEL_MODULES_OUT/extra/ || true | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/hid/hid-sensor-hub.ko $KERNEL_MODULES_OUT/extra/ || true | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/accel/hid-sensor-accel-3d.ko $KERNEL_MODULES_OUT/extra/ || true | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/gyro/hid-sensor-gyro-3d.ko $KERNEL_MODULES_OUT/extra/ || true | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/common/hid-sensors/hid-sensor-trigger.ko $KERNEL_MODULES_OUT/extra/ || true | |
| # RealSense cameras support | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/usb/uvc/uvcvideo.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/v4l2-core/videodev.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/usb/uvc/uvcvideo.ko $KERNEL_MODULES_OUT/extra/ || true | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/v4l2-core/videodev.ko $KERNEL_MODULES_OUT/extra/ || true | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/buffer/kfifo_buf.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/buffer/industrialio-triggered-buffer.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/common/hid-sensors/hid-sensor-iio-common.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/hid/hid-sensor-hub.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/accel/hid-sensor-accel-3d.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/gyro/hid-sensor-gyro-3d.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/iio/common/hid-sensors/hid-sensor-trigger.ko $KERNEL_MODULES_OUT/extra/ | |
| # RealSense cameras support | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/usb/uvc/uvcvideo.ko $KERNEL_MODULES_OUT/extra/ | |
| cp $KERNEL_MODULES_OUT/kernel/drivers/media/v4l2-core/videodev.ko $KERNEL_MODULES_OUT/extra/ |
|
|
||
| # Stage all modified files after patching | ||
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" add -A | ||
| [[ -d "sources_$SOURCES_VERSION/$KERNEL_DIR" ]] && git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" add -A | ||
| if [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" ]]; then | ||
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" add -A | ||
| elif [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" ]]; then | ||
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" add -A | ||
| fi | ||
|
|
||
| # Get author identity from root repo | ||
| GIT_AUTHOR_NAME=$(git config user.name) | ||
| GIT_AUTHOR_EMAIL=$(git config user.email) | ||
|
|
||
| # Update local git identity for subrepos | ||
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" config user.name "$GIT_AUTHOR_NAME" | ||
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" config user.email "$GIT_AUTHOR_EMAIL" | ||
| if [[ -d "sources_$SOURCES_VERSION/$KERNEL_DIR" ]]; then | ||
| git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" config user.name "$GIT_AUTHOR_NAME" | ||
| git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" config user.email "$GIT_AUTHOR_EMAIL" | ||
| fi | ||
| if [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" ]]; then | ||
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" config user.name "$GIT_AUTHOR_NAME" | ||
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" config user.email "$GIT_AUTHOR_EMAIL" | ||
| elif [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" ]]; then | ||
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" config user.name "$GIT_AUTHOR_NAME" | ||
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" config user.email "$GIT_AUTHOR_EMAIL" | ||
| fi | ||
|
|
||
| # Commit all staged files | ||
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" commit -m "RS patched" || true | ||
| [[ -d "sources_$SOURCES_VERSION/$KERNEL_DIR" ]] && git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" commit -m "RS patched" || true | ||
| if [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" ]]; then | ||
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" commit -m "RS patched" || true | ||
| elif [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" ]]; then | ||
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" commit -m "RS patched" || true | ||
| fi |
There was a problem hiding this comment.
Script now stages and auto-commits patched files in subrepos (git commit -m "RS patched"), which may create unintended local commits; avoid auto-committing or require explicit user confirmation.
Details
✨ AI Reasoning
apply_patches.sh now stages files and runs git commit in nested source repositories automatically after applying patches. This introduces automatic local commits to subrepos (git -C ... commit -m "RS patched"), which may be accidental and alter user working trees unexpectedly. Such automatic commits in scripts can lead to unintentional repository state changes.
🔧 How do I fix it?
Remove debugging statements like console.log, debugger, dd(), or logic bypasses like || true. Keep legitimate logging for monitoring and error handling.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Show Fix
Remediation - low confidence
This patch mitigates automatic git staging and committing of patched files in subrepos by removing the unintended debug artifact that created local commits without user confirmation.
| # Stage all modified files after patching | |
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" add -A | |
| [[ -d "sources_$SOURCES_VERSION/$KERNEL_DIR" ]] && git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" add -A | |
| if [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" ]]; then | |
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" add -A | |
| elif [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" ]]; then | |
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" add -A | |
| fi | |
| # Get author identity from root repo | |
| GIT_AUTHOR_NAME=$(git config user.name) | |
| GIT_AUTHOR_EMAIL=$(git config user.email) | |
| # Update local git identity for subrepos | |
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" config user.name "$GIT_AUTHOR_NAME" | |
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" config user.email "$GIT_AUTHOR_EMAIL" | |
| if [[ -d "sources_$SOURCES_VERSION/$KERNEL_DIR" ]]; then | |
| git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" config user.name "$GIT_AUTHOR_NAME" | |
| git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" config user.email "$GIT_AUTHOR_EMAIL" | |
| fi | |
| if [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" ]]; then | |
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" config user.name "$GIT_AUTHOR_NAME" | |
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" config user.email "$GIT_AUTHOR_EMAIL" | |
| elif [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" ]]; then | |
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" config user.name "$GIT_AUTHOR_NAME" | |
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" config user.email "$GIT_AUTHOR_EMAIL" | |
| fi | |
| # Commit all staged files | |
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" commit -m "RS patched" || true | |
| [[ -d "sources_$SOURCES_VERSION/$KERNEL_DIR" ]] && git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" commit -m "RS patched" || true | |
| if [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" ]]; then | |
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/t23x/nv-public" commit -m "RS patched" || true | |
| elif [[ -d "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" ]]; then | |
| git -C "sources_$SOURCES_VERSION/hardware/nvidia/platform/t19x/galen/kernel-dts" commit -m "RS patched" || true | |
| fi |
| cp "${IMG_DIR}/arch/arm64/boot/Image" "${DEST_DIR}/" 2>/dev/null || true | ||
| cp "${IMG_DIR}/arch/arm64/boot/dts/nvidia/tegra194-p2888-0001-p2822-0000.dtb" "${DEST_DIR}/" 2>/dev/null || true | ||
| cp "${IMG_DIR}/drivers/media/i2c/d4xx.ko" "${DEST_DIR}/" 2>/dev/null || true | ||
| cp "${IMG_DIR}/drivers/media/i2c/max96712.ko" "${DEST_DIR}/" 2>/dev/null || true | ||
| cp "${IMG_DIR}/drivers/media/usb/uvc/uvcvideo.ko" "${DEST_DIR}/" 2>/dev/null || true | ||
| cp "${IMG_DIR}/drivers/media/v4l2-core/videobuf-core.ko" "${DEST_DIR}/" 2>/dev/null || true | ||
| cp "${IMG_DIR}/drivers/media/v4l2-core/videobuf-vmalloc.ko" "${DEST_DIR}/" 2>/dev/null || true |
There was a problem hiding this comment.
Copy commands were changed to 'cp ... 2>/dev/null || true', which hides copy failures; avoid '|| true' or check file existence before copying to prevent silent failures.
Details
✨ AI Reasoning
the source_sync/pack scripts (deploy_kernel.sh) now copy several files with 'cp ... 2>/dev/null || true', intentionally swallowing failures. With set -e semantics or expected invariants, silencing errors can hide mis-syncs or missing artifacts introduced by this change. Restoring explicit error handling or checking existence before copying would surface issues.
🔧 How do I fix it?
Remove debugging statements like console.log, debugger, dd(), or logic bypasses like || true. Keep legitimate logging for monitoring and error handling.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Show Fix
Remediation - low confidence
This patch mitigates silent failure bypass artifacts by removing the '2>/dev/null || true' error suppression from copy commands on lines 54-60, restoring proper error handling to surface missing files or copy failures.
| cp "${IMG_DIR}/arch/arm64/boot/Image" "${DEST_DIR}/" 2>/dev/null || true | |
| cp "${IMG_DIR}/arch/arm64/boot/dts/nvidia/tegra194-p2888-0001-p2822-0000.dtb" "${DEST_DIR}/" 2>/dev/null || true | |
| cp "${IMG_DIR}/drivers/media/i2c/d4xx.ko" "${DEST_DIR}/" 2>/dev/null || true | |
| cp "${IMG_DIR}/drivers/media/i2c/max96712.ko" "${DEST_DIR}/" 2>/dev/null || true | |
| cp "${IMG_DIR}/drivers/media/usb/uvc/uvcvideo.ko" "${DEST_DIR}/" 2>/dev/null || true | |
| cp "${IMG_DIR}/drivers/media/v4l2-core/videobuf-core.ko" "${DEST_DIR}/" 2>/dev/null || true | |
| cp "${IMG_DIR}/drivers/media/v4l2-core/videobuf-vmalloc.ko" "${DEST_DIR}/" 2>/dev/null || true | |
| cp "${IMG_DIR}/arch/arm64/boot/Image" "${DEST_DIR}/" | |
| cp "${IMG_DIR}/arch/arm64/boot/dts/nvidia/tegra194-p2888-0001-p2822-0000.dtb" "${DEST_DIR}/" | |
| cp "${IMG_DIR}/drivers/media/i2c/d4xx.ko" "${DEST_DIR}/" | |
| cp "${IMG_DIR}/drivers/media/i2c/max96712.ko" "${DEST_DIR}/" | |
| cp "${IMG_DIR}/drivers/media/usb/uvc/uvcvideo.ko" "${DEST_DIR}/" | |
| cp "${IMG_DIR}/drivers/media/v4l2-core/videobuf-core.ko" "${DEST_DIR}/" | |
| cp "${IMG_DIR}/drivers/media/v4l2-core/videobuf-vmalloc.ko" "${DEST_DIR}/" |
|
Closing to resubmit PR against dev branch instead of master |
There was a problem hiding this comment.
Pull request overview
Updates documentation/branding and extends JetPack tooling and kernel patch sets (notably adding JetPack 6.2.1 support and additional kernel/driver patch payloads).
Changes:
- Update docs branding/links and remove Intel® references; replace broken store links with text-only mentions.
- Add/extend JetPack 6.2.1 support across setup/build scripts and kernel patch directories.
- Add new deploy/install scripts and adjust patch application flows (including symlink handling and subrepo commit behavior).
Reviewed changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| setup_workspace.sh | Advertises JetPack 6.2.1 support in help output. |
| scripts/source_sync_6.x.sh | Changes clone protocol preference and removes nvethernetrm link creation (moved elsewhere). |
| scripts/source_sync_5.1.2.sh | Changes clone protocol preference (git:// first, https fallback). |
| scripts/source_sync_5.0.2.sh | Changes clone protocol preference (git:// first, https fallback). |
| scripts/source_sync_4.6.1.sh | Changes clone protocol preference (git:// first, https fallback). |
| scripts/setup-common | Extends JetPack 6.x version parsing and adds 6.2.1 revision mapping. |
| scripts/install_to_kernel.sh | Adds a local install script to copy kernel/modules/boot artifacts and reboot. |
| scripts/deploy_kernel.sh | Adds packaging + remote deploy wrapper via SSH and triggers remote install script. |
| scripts/aggregate_kernel_6.x.sh | Extends validation/help to include kernel version 6.2.1. |
| nvidia-oot/6.2/0004-Add-GPIO-tunneling-for-the-external-sync-support.patch | Adds 6.2 patch entry pointing to the 6.0 patch content. |
| nvidia-oot/6.2.1/0004-Add-GPIO-tunneling-for-the-external-sync-support.patch | Adds 6.2.1 patch entry pointing to the 6.0 patch content. |
| nvidia-oot/6.2.1/0003-Fix-y12i-calibration-stream.patch | Adds 6.2.1 patch entry pointing to the 6.0 patch content. |
| nvidia-oot/6.2.1/0002-Adding-stream-restart-upon-capture-timeout.patch | Adds a VI capture-timeout recovery patch for 6.2.1. |
| nvidia-oot/6.2.1/0001-Porting-nvidia-driver-patches-to-jetpack-6.0.patch | Large nvidia-oot patch payload (formats, metadata, SERDES helpers, etc.). |
| nvidia-oot/6.1/0004-Add-GPIO-tunneling-for-the-external-sync-support.patch | Adds 6.1 patch entry pointing to the 6.0 patch content. |
| nvidia-oot/6.0/0004-Add-GPIO-tunneling-for-the-external-sync-support.patch | Adds GPIO tunneling changes for external sync in max9295/max9296. |
| kernel/realsense/d4xx.c | Adds D40x support, custom formats, and HW reset-with-recovery logic; bumps module version. |
| kernel/nvidia/5.1.2/0005-Add-GPIO-tunneling-for-the-external-sync-support.patch | Adds GPIO tunneling patch for JP 5.1.2 kernel. |
| kernel/nvidia/5.0.2/0015-Add-GPIO-tunneling-for-the-external-sync-support.patch | Adds GPIO tunneling patch for JP 5.0.2 kernel. |
| kernel/kernel-jammy-src/6.2.1/0005-support-for-dynamic-change-of-i2c-bus-clk-rate.patch | Adds sysfs and APIs to change I2C adapter clock rate dynamically (jammy 6.2.1 set). |
| kernel/kernel-jammy-src/6.2.1/0004-realsense-powerlinefrequency-control-fix-jammy.patch | Adds missing “Auto” menu entry for PowerLineFrequency in UVC control map. |
| kernel/kernel-jammy-src/6.2.1/0003-realsense-metadata-jammy-master.patch | Adds UVC metadata support and expands UVC status buffer size. |
| kernel/kernel-jammy-src/6.2.1/0002-realsense-camera-formats-jammy-master.patch | Adds RealSense/Librealsense pixel formats and GUID mappings. |
| kernel/kernel-jammy-src/6.2.1/0001-kernel-enable-HID_SENSOR-without-USB-impact.patch | Enables HID sensor modules in defconfig (jammy 6.2.1 set). |
| build_all.sh | Adds --clean option and makes module copy steps tolerant to missing artifacts. |
| apply_patches.sh | Moves nvethernetrm symlink creation here; tracks/reset base commits; stages & commits changes in subrepos. |
| Security.md | Updates branding and replaces Intel reporting link with repo-based reporting guidance. |
| README_tools.md | Updates branding and removes broken DES457 store link (text-only mention). |
| README_driver.md | Updates branding in headings/links. |
| README_JP6.2.md | Updates branding, adds JetPack 6.2.1 mention, updates repo/store URLs, removes broken DES457 link. |
| README_JP6.0.md | Updates branding, repository URL, store link, removes broken DES457 link. |
| README_JP5.md | Updates branding, store link reference, removes broken DES457 link. |
| README_JP4.md | Updates branding, store link reference, removes broken DES457 link. |
| README.md | Adds logo header, updates supported JP versions, updates store URL and DES457 mention. |
| COPYRIGHT.md | Updates branding language. |
| CODE_OF_CONDUCT.md | Updates branding in heading. |
Comments suppressed due to low confidence (1)
nvidia-oot/6.2.1/0001-Porting-nvidia-driver-patches-to-jetpack-6.0.patch:1
- This change bypasses
v4l2_subdev_call()and directly dereferencessd->ops->video->g_frame_interval, which can NULL-deref ifops,video, org_frame_intervalare absent (wherev4l2_subdev_call()would safely return-ENOIOCTLCMD). Prefer keepingv4l2_subdev_call()(and handling its return) or add a safe check before dereferencing the ops chain.
From 1ce2b2e647c63724bfd1434f963eabbe4aa83941 Mon Sep 17 00:00:00 2001
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,78 @@ | |||
|
|
|||
There was a problem hiding this comment.
The script starts with a blank line before the shebang, so the kernel won't honor #!/bin/bash when executing the file directly; it will typically fall back to /bin/sh, which can break bash-specific syntax used later. Remove the leading blank line so the shebang is the first bytes of the file.
| # Set defaults | ||
| JETPACK_VERSION="$1" | ||
| TARGET="$2" | ||
| USERNAME="${3:-administrator}" | ||
| REMOTE_PATH="${4:-dev}" | ||
| REMOTE_BOOT_FOLDER="${5:-dev}" |
There was a problem hiding this comment.
The help text says TARGET is optional, but the script will still attempt SSH/SCP when only JETPACK_VERSION is provided (i.e., $# == 1), because it checks $# -eq 0 instead of whether TARGET is set. Change the condition to check for an empty TARGET (e.g., if [ -z \"$TARGET\" ]; then ...) so local-only packaging works as documented.
| if [ "$#" -eq 0 ]; then | ||
| echo "No TARGET specified, skipping copy and reboot." | ||
| else | ||
| echo "Copying files and setting permissions on remote host..." | ||
| cp ${LOCAL_DIR}/scripts/install_to_kernel.sh ${LOCAL_DIR}/kernel_mod/${JETPACK_VERSION}/ | ||
| # Use SSH ControlMaster to reuse a single SSH connection | ||
| CONTROL_PATH="/tmp/ssh-control-${USERNAME}-${TARGET}" | ||
| ssh -o ControlMaster=yes -o ControlPath="${CONTROL_PATH}" -o ControlPersist=10s -fN ${USERNAME}@${TARGET} |
There was a problem hiding this comment.
The help text says TARGET is optional, but the script will still attempt SSH/SCP when only JETPACK_VERSION is provided (i.e., $# == 1), because it checks $# -eq 0 instead of whether TARGET is set. Change the condition to check for an empty TARGET (e.g., if [ -z \"$TARGET\" ]; then ...) so local-only packaging works as documented.
| sudo mkdir /boot/${FOLDER} | ||
| fi | ||
|
|
||
| # Only extract and use rootfs.tar.gz for 5.0.2 and 5.1.2 |
There was a problem hiding this comment.
The comment says rootfs.tar.gz is only extracted for 5.0.2/5.1.2, but the 6.x branch also extracts it. Update the comment to reflect the actual behavior (or adjust the code to match the intended behavior).
| # Only extract and use rootfs.tar.gz for 5.0.2 and 5.1.2 | |
| # Extract and use rootfs.tar.gz for JetPack 5.0.2 and 5.1.2 (6.x versions extract it in the branch below) |
| elif [ "${JETPACK_VERSION}" = "6.0" ] || [ "${JETPACK_VERSION}" = "6.1" ] || [ "${JETPACK_VERSION}" = "6.2" ] || [ "${JETPACK_VERSION}" = "6.2.1" ]; then | ||
| tar xf rootfs.tar.gz |
There was a problem hiding this comment.
The comment says rootfs.tar.gz is only extracted for 5.0.2/5.1.2, but the 6.x branch also extracts it. Update the comment to reflect the actual behavior (or adjust the code to match the intended behavior).
| # Store the original commit hash before applying patches | ||
| ORIGINAL_COMMIT=$(git -C "sources_$SOURCES_VERSION/$3" rev-parse HEAD) | ||
| echo "$ORIGINAL_COMMIT" > "sources_$SOURCES_VERSION/$3/.realsense_patch_base" |
There was a problem hiding this comment.
.realsense_patch_base is overwritten on every apply, which can break reset behavior if the user applies patches multiple times (the stored base may become the already-patched commit). Only create .realsense_patch_base if it does not already exist, or store per-action state in a way that preserves the true original base.
| # Store the original commit hash before applying patches | |
| ORIGINAL_COMMIT=$(git -C "sources_$SOURCES_VERSION/$3" rev-parse HEAD) | |
| echo "$ORIGINAL_COMMIT" > "sources_$SOURCES_VERSION/$3/.realsense_patch_base" | |
| # Store the original commit hash before applying patches, but only if not already stored | |
| if [[ ! -f "sources_$SOURCES_VERSION/$3/.realsense_patch_base" ]]; then | |
| ORIGINAL_COMMIT=$(git -C "sources_$SOURCES_VERSION/$3" rev-parse HEAD) | |
| echo "$ORIGINAL_COMMIT" > "sources_$SOURCES_VERSION/$3/.realsense_patch_base" | |
| fi |
| # Get author identity from root repo | ||
| GIT_AUTHOR_NAME=$(git config user.name) | ||
| GIT_AUTHOR_EMAIL=$(git config user.email) |
There was a problem hiding this comment.
Auto-committing inside vendor/source subrepos with || true can silently leave repos in a partially-patched, dirty state (e.g., if user.name/email are unset or hooks reject the commit). Consider either (a) avoiding commits entirely and keeping changes as a working tree modification, or (b) validating GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL and failing fast (or prompting) if commits are intended and cannot be created.
| # Commit all staged files | ||
| git -C "sources_$SOURCES_VERSION/$D4XX_SRC_DST" commit -m "RS patched" || true | ||
| [[ -d "sources_$SOURCES_VERSION/$KERNEL_DIR" ]] && git -C "sources_$SOURCES_VERSION/$KERNEL_DIR" commit -m "RS patched" || true |
There was a problem hiding this comment.
Auto-committing inside vendor/source subrepos with || true can silently leave repos in a partially-patched, dirty state (e.g., if user.name/email are unset or hooks reject the commit). Consider either (a) avoiding commits entirely and keeping changes as a working tree modification, or (b) validating GIT_AUTHOR_NAME/GIT_AUTHOR_EMAIL and failing fast (or prompting) if commits are intended and cannot be created.
| int ret; | ||
| int retry; | ||
| u16 status = 0; | ||
| bool device_went_down = false; |
There was a problem hiding this comment.
device_went_down is set but never used, which can trigger -Wunused-but-set-variable warnings depending on the build flags (and may become a build break if warnings are treated as errors). Remove the variable or use it (e.g., to distinguish 'never went down' vs 'went down and recovered' in logs/logic).
| bool device_went_down = false; | |
| bool device_went_down __maybe_unused = false; |
| if (ret < 0) { | ||
| /* I2C failed - device is resetting (expected during reset) */ | ||
| device_went_down = true; |
There was a problem hiding this comment.
device_went_down is set but never used, which can trigger -Wunused-but-set-variable warnings depending on the build flags (and may become a build break if warnings are treated as errors). Remove the variable or use it (e.g., to distinguish 'never went down' vs 'went down and recovered' in logs/logic).
Summary
Test plan
🤖 Generated with Claude Code