Update README links: migrate to realsenseai GitHub and store #352
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,23 +1,23 @@ | ||||||
| # RealSense™ camera driver for GMSL* interface | ||||||
|
|
||||||
| # D457 MIPI on NVIDIA® Jetson AGX Orin™ JetPack 6.x | ||||||
| The RealSense™ MIPI platform driver enables the user to control and stream RealSense™ 3D MIPI cameras. | ||||||
| The system shall include: | ||||||
| * NVIDIA® Jetson™ platform Supported JetPack versions are: | ||||||
| - [6.2 production release](https://developer.nvidia.com/embedded/jetpack-sdk-62) | ||||||
| - [6.1 production release](https://developer.nvidia.com/embedded/jetpack-sdk-61) | ||||||
| - [6.0 production release](https://developer.nvidia.com/embedded/jetpack-sdk-60) | ||||||
| * RealSense™ De-Serialize board (DS457) | ||||||
|
|
||||||
| * Jetson AGX Orin™ Passive adapter board from [Leopard Imaging® LI-JTX1-SUB-ADPT](https://leopardimaging.com/product/accessories/adapters-carrier-boards/for-nvidia-jetson/li-jtx1-sub-adpt/) | ||||||
| * RS MIPI camera [D457](https://store.realsenseai.com/buy-intel-realsense-depth-camera-d457.html) | ||||||
|
|
||||||
|  | ||||||
|
|
||||||
|
|
||||||
| > Note: This MIPI reference driver is based on RealSense™ de-serialize board. For other de-serialize boards, modification might be needed. | ||||||
|
There was a problem hiding this comment. The DES457 hardware is referred to with two different forms (“De-Serialize” vs “de-serialize”) a few lines apart. Please pick one term/capitalization and use it consistently to avoid confusion (especially for readers searching the doc).
Suggested change
|
||||||
|
|
||||||
| ### Links | ||||||
| - RealSense™ camera driver for GMSL* interface [Front Page](./README.md) | ||||||
| - NVIDIA® Jetson AGX Orin™ board setup - AGX Orin™ [JetPack 6.0](./README_JP6.0.md) setup guide | ||||||
| - NVIDIA® Jetson AGX Xavier™ board setup - AGX Xavier™ [JetPack 5.x.2](./README_JP5.md) setup guide | ||||||
| - NVIDIA® Jetson AGX Xavier™ board setup - AGX Xavier™ [JetPack 4.6.1](./README_JP4.md) setup guide | ||||||
|
|
@@ -36,7 +36,7 @@ sudo apt-get install -y build-essential bc wget flex bison curl libssl-dev xxd t | |||||
| ``` | ||||||
| ## Build NVIDIA® kernel drivers, dtb and D457 driver | ||||||
|
|
||||||
| 1. Clone [realsense_mipi_platform_driver](https://github.com/realsenseai/realsense_mipi_platform_driver.git) repo. | ||||||
| 2. The developers can set up build environment, ARM64 compiler, kernel sources and NVIDIA's Jetson git repositories by using the setup script. | ||||||
| 3. Apply patches for kernel drivers, nvidia-oot module and tegra devicetree. | ||||||
| 4. Build project | ||||||
|
|
@@ -45,7 +45,7 @@ sudo apt-get install -y build-essential bc wget flex bison curl libssl-dev xxd t | |||||
|
|
||||||
| Assuming building for 6.0. One can also build for 6.1, 6.2 just replace the last parameter. | ||||||
| ``` | ||||||
| git clone --branch dev --single-branch https://github.com/realsenseai/realsense_mipi_platform_driver.git | ||||||
| cd realsense_mipi_platform_driver | ||||||
| ./setup_workspace.sh 6.0 | ||||||
| ./apply_patches.sh 6.0 | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -46,7 +46,7 @@ Reset D457 patches (and any other changes) for kernel image, dtb and D457 driver | |||||
| ``` | ||||||
|
|
||||||
| Note: The `--one-cam` and `--dual-cam` option applies only for JetPack 5.0.2, | ||||||
| compatible with RealSense™ DES457 deserializer. | ||||||
|
There was a problem hiding this comment. This reads a bit ambiguous compared to the other READMEs that call it a board. Consider aligning wording to something like “compatible with the RealSense™ DES457 deserializer board” (or whatever standardized term you choose elsewhere) so readers understand it’s a specific hardware component.
Suggested change
|
||||||
| - By setting the `--one-cam` option it builds DT with only camera on GMSL link A (default). | ||||||
|
|
||||||
| - By setting the `--dual-cam` option it builds DT with dual cameras on GMSL link A and B. | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terminology/branding is inconsistent within the same section: the bullet uses “RealSense™ De-Serialize board (DES457)” while the note says “RealSense de-serialize board” (no ™) and uses a different capitalization/hyphenation. Please standardize the phrasing across the README (e.g., consistently use “RealSense™ DES457 deserializer board” or consistently use “de-serialize board”).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here (DS457)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot remove (DS457)