Calibration wo metadata - #364
Merged
Merged
Conversation
* Disabled data_teyp2 for calib format * Added overlays for calib mode Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
There was a problem hiding this comment.
Pull request overview
Updates Jetson Orin (Tegra234) RealSense D4xx kernel + device-tree overlay configuration to support calibration-specific streaming behavior (notably around metadata handling) across multiple SerDes setups.
Changes:
- Adjusts D4xx SerDes pipeline configuration to treat a specific Y8 “calibration” mode differently (disables second data type and triggers a one-shot reset).
- Updates/extends Tegra234 camera DT overlays (including new
*.calib.dtsoverlays) and refreshes overlay display names and endpoint wiring. - Updates the downstream NVIDIA overlay Makefile patch to build/install the added calibration DTBOs; bumps kernel module version.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kernel/realsense/d4xx.c | Adds “calibration” detection in SerDes pipeline setup and bumps module version. |
| hardware/realsense/tegra234-camera-d4xx-overlay.dts | Updates overlay-name string for clarity. |
| hardware/realsense/tegra234-camera-d4xx-overlay.calib.dts | Updates overlay-name and rewires endpoints / stream modes for calibration usage (including embedded metadata height changes). |
| hardware/realsense/tegra234-camera-d4xx-overlay-max96712-EVB.dts | Updates overlay-name string for clarity. |
| hardware/realsense/tegra234-camera-d4xx-overlay-max96712-EVB.calib.dts | Adds a new calibration overlay for max96712 EVB configuration. |
| hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch.dts | Updates overlay-name string for clarity. |
| hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch.calib.dts | Adds a new calibration overlay for fg12-16ch configuration. |
| hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch-quad.dts | Updates overlay-name string for clarity. |
| hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch-quad.calib.dts | Adds a new calibration overlay for fg12-16ch QUAD configuration. |
| hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch-dual.dts | Updates overlay-name string for clarity. |
| hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch-dual.calib.dts | Adds a new calibration overlay for fg12-16ch DUAL configuration. |
| hardware/realsense/tegra234-camera-d4xx-overlay-dual.dts | Updates overlay-name string for clarity. |
| hardware/realsense/tegra234-camera-d4xx-overlay-dual.calib.dts | Updates overlay-name string for clarity. |
| hardware/nvidia/t23x/nv-public/6.x/0001-overlay-enable-d4xx-camera-for-Orin-jp6.patch | Extends the overlay/Makefile patch to include calibration DTBO targets. |
Comments suppressed due to low confidence (2)
kernel/realsense/d4xx.c:1701
- Initialize
is_calibwithfalseinstead of0to match the file’s existing boolean style (e.g.,device_went_down = false) and avoid mixing integer literals withbool.
bool is_calib = 0;
kernel/realsense/d4xx.c:1795
- The inline comment says this reset is for “switching to Y12I”, but the condition is now
is_calib(Y8 stream withGMSL_CSI_DT_RGB_888). Please update the comment to reflect the actual scenario/reason for the oneshot reset (or adjust the condition if Y12I was intended).
// reset data path when switching to Y12I
if (is_calib)
state->dser_ops->reset_oneshot(state->dser_dev);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ymodlin
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.