Skip to content

Calibration wo metadata - #364

Merged
ejgoldik merged 2 commits into
devfrom
Calibration_wo_metadata
Feb 19, 2026
Merged

Calibration wo metadata#364
ejgoldik merged 2 commits into
devfrom
Calibration_wo_metadata

Conversation

@ejgoldik

Copy link
Copy Markdown
Contributor

No description provided.

* Disabled data_teyp2 for calib format
* Added overlays for calib mode

Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
Signed-off-by: ejgoldik <ehud.joseph.goldik@realsenseai.com>
Copilot AI review requested due to automatic review settings February 19, 2026 10:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Jetson Orin (Tegra234) RealSense D4xx kernel + device-tree overlay configuration to support calibration-specific streaming behavior (notably around metadata handling) across multiple SerDes setups.

Changes:

  • Adjusts D4xx SerDes pipeline configuration to treat a specific Y8 “calibration” mode differently (disables second data type and triggers a one-shot reset).
  • Updates/extends Tegra234 camera DT overlays (including new *.calib.dts overlays) and refreshes overlay display names and endpoint wiring.
  • Updates the downstream NVIDIA overlay Makefile patch to build/install the added calibration DTBOs; bumps kernel module version.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
kernel/realsense/d4xx.c Adds “calibration” detection in SerDes pipeline setup and bumps module version.
hardware/realsense/tegra234-camera-d4xx-overlay.dts Updates overlay-name string for clarity.
hardware/realsense/tegra234-camera-d4xx-overlay.calib.dts Updates overlay-name and rewires endpoints / stream modes for calibration usage (including embedded metadata height changes).
hardware/realsense/tegra234-camera-d4xx-overlay-max96712-EVB.dts Updates overlay-name string for clarity.
hardware/realsense/tegra234-camera-d4xx-overlay-max96712-EVB.calib.dts Adds a new calibration overlay for max96712 EVB configuration.
hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch.dts Updates overlay-name string for clarity.
hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch.calib.dts Adds a new calibration overlay for fg12-16ch configuration.
hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch-quad.dts Updates overlay-name string for clarity.
hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch-quad.calib.dts Adds a new calibration overlay for fg12-16ch QUAD configuration.
hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch-dual.dts Updates overlay-name string for clarity.
hardware/realsense/tegra234-camera-d4xx-overlay-fg12-16ch-dual.calib.dts Adds a new calibration overlay for fg12-16ch DUAL configuration.
hardware/realsense/tegra234-camera-d4xx-overlay-dual.dts Updates overlay-name string for clarity.
hardware/realsense/tegra234-camera-d4xx-overlay-dual.calib.dts Updates overlay-name string for clarity.
hardware/nvidia/t23x/nv-public/6.x/0001-overlay-enable-d4xx-camera-for-Orin-jp6.patch Extends the overlay/Makefile patch to include calibration DTBO targets.
Comments suppressed due to low confidence (2)

kernel/realsense/d4xx.c:1701

  • Initialize is_calib with false instead of 0 to match the file’s existing boolean style (e.g., device_went_down = false) and avoid mixing integer literals with bool.
	bool is_calib = 0;

kernel/realsense/d4xx.c:1795

  • The inline comment says this reset is for “switching to Y12I”, but the condition is now is_calib (Y8 stream with GMSL_CSI_DT_RGB_888). Please update the comment to reflect the actual scenario/reason for the oneshot reset (or adjust the condition if Y12I was intended).
		// reset data path when switching to Y12I
		if (is_calib)
			state->dser_ops->reset_oneshot(state->dser_dev);

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ejgoldik
ejgoldik merged commit 3cf003d into dev Feb 19, 2026
12 checks passed
@ejgoldik
ejgoldik deleted the Calibration_wo_metadata branch March 22, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants