fix(dask): respect runtime namespace when deleting Dask clusters#675
Merged
tiborsimko merged 1 commit intoreanahub:masterfrom Apr 13, 2026
Merged
Conversation
…nahub#675) Several Dask cluster deletion functions used hard-coded "default" namespace instead of respecting the runtime namespace as the Dask cluster creation functions were doing. This commit fixes the mismatch that would otherwise cause cleanup procedures to silently target the wrong namespace in non-default deployments.
tiborsimko
force-pushed
the
fix-dask-delete-cluster-namespace
branch
from
9d4ea63 to
fb48ea3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
=======================================
Coverage 73.55% 73.55%
=======================================
Files 17 17
Lines 2004 2004
=======================================
Hits 1474 1474
Misses 530 530
🚀 New features to boost your workflow:
|
michaelbuchar
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several Dask cluster deletion functions used hard-coded "default" namespace instead of respecting the runtime namespace as the Dask cluster creation functions were doing. This commit fixes the mismatch that would otherwise cause cleanup procedures to silently target the wrong namespace in non-default deployments.