Skip to content

fix(dask): respect runtime namespace when deleting Dask clusters #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiborsimko merged 1 commit into from
Apr 13, 2026
Merged

fix(dask): respect runtime namespace when deleting Dask clusters #675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions reana_workflow_controller/dask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ def delete_dask_cluster(workflow_id, user_id) -> None:
group="kubernetes.dask.org",
version="v1",
plural="daskclusters",
namespace="default",
namespace=REANA_RUNTIME_KUBERNETES_NAMESPACE,
name=get_dask_component_name(workflow_id, "cluster"),
)
logging.info(f"Dask cluster for workflow {workflow_id} deleted successfully.")
Expand All @@ -645,7 +645,7 @@ def delete_dask_cluster(workflow_id, user_id) -> None:
group="kubernetes.dask.org",
version="v1",
plural="daskautoscalers",
namespace="default",
namespace=REANA_RUNTIME_KUBERNETES_NAMESPACE,
name=get_dask_component_name(workflow_id, "autoscaler"),
)
logging.info(
Expand Down Expand Up @@ -765,13 +765,13 @@ def create_dask_dashboard_ingress(workflow_id, user_id):
current_k8s_custom_objects_api_client.create_namespaced_custom_object(
group="traefik.io",
version="v1alpha1",
namespace="default",
namespace=REANA_RUNTIME_KUBERNETES_NAMESPACE,
plural="middlewares",
body=middleware_spec,
)
# Create the ingress resource
current_k8s_networking_api_client.create_namespaced_ingress(
namespace="default", body=ingress
namespace=REANA_RUNTIME_KUBERNETES_NAMESPACE, body=ingress
)


Expand All @@ -781,7 +781,7 @@ def delete_dask_dashboard_ingress(workflow_id):
try:
current_k8s_networking_api_client.delete_namespaced_ingress(
get_dask_component_name(workflow_id, "dashboard_ingress"),
namespace="default",
namespace=REANA_RUNTIME_KUBERNETES_NAMESPACE,
body=client.V1DeleteOptions(),
)
except Exception as e:
Expand All @@ -793,7 +793,7 @@ def delete_dask_dashboard_ingress(workflow_id):
current_k8s_custom_objects_api_client.delete_namespaced_custom_object(
group="traefik.io",
version="v1alpha1",
namespace="default",
namespace=REANA_RUNTIME_KUBERNETES_NAMESPACE,
plural="middlewares",
name=get_dask_component_name(workflow_id, "dashboard_ingress_middleware"),
)
Expand Down
Loading