Skip to content

Conversation

@AntonJames-Sistence
Copy link
Contributor

@AntonJames-Sistence AntonJames-Sistence commented Jul 28, 2025

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number:

  1. Animated edges bug Animated edges bug #346
  2. Edge context menu bug Edge context menu bug #345

What is the new behavior?

  1. Menu called on click of the edge can be closed
  2. Edges are the same size on animated={false} as in animated={true}
  3. Click on Edges doesn't call the native browser context menu anymore
Screen.Recording.2025-07-28.at.12.54.18.PM.mov

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for reagraph ready!

Name Link
🔨 Latest commit bffd5d2
🔍 Latest deploy log https://app.netlify.com/projects/reagraph/deploys/6887d78d738a9500080e843c
😎 Deploy Preview https://deploy-preview-352--reagraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AntonJames-Sistence
Copy link
Contributor Author

@SerhiiTsybulskyi Could you test this branch on your machine please, especially this piece: #345 (comment), I think I fixed it, but since I can't reproduce this bug, I don't have an opportunity to test

@SerhiiTsybulskyi
Copy link
Contributor

@SerhiiTsybulskyi Could you test this branch on your machine please, especially this piece: #345 (comment), I think I fixed it, but since I can't reproduce this bug, I don't have an opportunity to test

Hi @AntonJames-Sistence I've tested you branch on Windows OS and the issue with the context menu still reproduces.

The Edges size with animated={false} looks nice!


const fromVector = getVector(from);
const fromOffset = from.size + labelFontSize;
const fromOffset = from.size;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to know why this was removed ? Looks fishy at first glance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, this was to fix the difference in size of the arrows when animated={true} and animated={false}, I believe that was a bug: #346

@amcdnl amcdnl merged commit 38e028e into master Jul 29, 2025
5 checks passed
@amcdnl amcdnl deleted the anton/reagraph-346 branch July 29, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants