-
-
Notifications
You must be signed in to change notification settings - Fork 86
Anton/reagraph 346 #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anton/reagraph 346 #352
Conversation
✅ Deploy Preview for reagraph ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@SerhiiTsybulskyi Could you test this branch on your machine please, especially this piece: #345 (comment), I think I fixed it, but since I can't reproduce this bug, I don't have an opportunity to test |
Hi @AntonJames-Sistence I've tested you branch on Windows OS and the issue with the context menu still reproduces. The Edges size with |
|
|
||
| const fromVector = getVector(from); | ||
| const fromOffset = from.size + labelFontSize; | ||
| const fromOffset = from.size; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to know why this was removed ? Looks fishy at first glance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, this was to fix the difference in size of the arrows when animated={true} and animated={false}, I believe that was a bug: #346
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
What is the new behavior?
animated={false}as inanimated={true}Screen.Recording.2025-07-28.at.12.54.18.PM.mov
Does this PR introduce a breaking change?
Other information