Skip to content

Anton/reagraph 346 #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcdnl merged 3 commits into from
Jul 29, 2025
Merged

Anton/reagraph 346 #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4041056
fix non closing menu on edges
AntonJames-Sistence Jul 28, 2025
e20ad58
fix bug with short edges when animation is false
AntonJames-Sistence Jul 28, 2025
bffd5d2
add fix for the default browser menu
AntonJames-Sistence Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/symbols/Arrow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export const Arrow: FC<ArrowProps> = ({
onPointerDown={event => {
// context menu controls
if (event.nativeEvent.buttons === 2) {
event.nativeEvent.preventDefault();
event.stopPropagation();
onContextMenu();
}
Expand Down
1 change: 1 addition & 0 deletions src/symbols/Line.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ export const Line: FC<LineProps> = ({
onPointerDown={event => {
// context menu controls
if (event.nativeEvent.buttons === 2) {
event.nativeEvent.preventDefault();
event.stopPropagation();
onContextMenu();
}
Expand Down
5 changes: 3 additions & 2 deletions src/symbols/edges/Edge.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,9 @@ export const Edge: FC<EdgeProps> = ({

const removeContextMenu = useCallback(
(edgeId: string) => {
edgeContextMenus.delete(edgeId);
setEdgeContextMenus(new Set(edgeContextMenus));
const newEdgeContextMenus = new Set(edgeContextMenus);
newEdgeContextMenus.delete(edgeId);
setEdgeContextMenus(newEdgeContextMenus);
},
[edgeContextMenus, setEdgeContextMenus]
);
Expand Down
4 changes: 2 additions & 2 deletions src/symbols/edges/useEdgeGeometry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,9 +89,9 @@ export function useEdgeGeometry(
}

const fromVector = getVector(from);
const fromOffset = from.size + labelFontSize;
const fromOffset = from.size;
Copy link
Member

@amcdnl amcdnl Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to know why this was removed ? Looks fishy at first glance.

Copy link
Contributor Author

@AntonJames-Sistence AntonJames-Sistence Jul 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, this was to fix the difference in size of the arrows when animated={true} and animated={false}, I believe that was a bug: #346

const toVector = getVector(to);
const toOffset = to.size + labelFontSize;
const toOffset = to.size;
let curve = getCurve(
fromVector,
fromOffset,
Expand Down