Dokka: fix compatibility with multiplatform and configuration cache #1493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes many "<Error class: unknown class>" such as with LiveData and RecyclerView as well as potential conflicts in class names between modules
Luna712
commented
Jan 17, 2025
Luna712
changed the title
Luna712
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes many
<Error class: unknown class>such as with LiveData and RecyclerView as well as potential conflicts in class names between modulesTODO:
Fix<Error class: unknown class>for DataBinding classesFix<Error class: unknown class>R class<Error class: unknown class>for some jackson and nicehttp classes in library onlyI had DataBinding and R fixed locally by adding the directories the generated files are in to sourceRoots, however that means the dokka script action would also need to build the entire app to get there so decided not to push here, We may be able to find a solution later but testing this locally it seems to fix every other remaining
<Error class: unknown class>issue.This also significantly simplifies the dokka configuration and removes the need to maintain the
dokkaImplementationdependencies separately.Removes libs that were only used in docs as well.
Also, this combined with #1494 adds full support for configuration and build cache across cloudstream entirely.