Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dokka: fix compatibility with multiplatform and configuration cache #1493

Merged
merged 7 commits into from
Jan 21, 2025

Conversation

Luna712
Copy link
Contributor

@Luna712 Luna712 commented Jan 16, 2025

Fixes many <Error class: unknown class> such as with LiveData and RecyclerView as well as potential conflicts in class names between modules

TODO:

  • Fix <Error class: unknown class> for DataBinding classes
  • Fix <Error class: unknown class> R class
  • Fix <Error class: unknown class> for some jackson and nicehttp classes in library only
  • Fix missing source link in App module
  • Fix overall project to be Cloudstream again

I had DataBinding and R fixed locally by adding the directories the generated files are in to sourceRoots, however that means the dokka script action would also need to build the entire app to get there so decided not to push here, We may be able to find a solution later but testing this locally it seems to fix every other remaining <Error class: unknown class> issue.

This also significantly simplifies the dokka configuration and removes the need to maintain the dokkaImplementation dependencies separately.

Removes libs that were only used in docs as well.

Also, this combined with #1494 adds full support for configuration and build cache across cloudstream entirely.

Fixes many "<Error class: unknown class>" such as with LiveData and RecyclerView as well as potential conflicts in class names between modules
@Luna712 Luna712 marked this pull request as ready for review January 17, 2025 03:21
@Luna712 Luna712 changed the title Dokka: fix compatibility with multiplatform/modules Dokka: fix compatibility with multiplatform Jan 17, 2025
@Luna712 Luna712 changed the title Dokka: fix compatibility with multiplatform Dokka: fix compatibility with multiplatform and configuration cache Jan 18, 2025
@fire-light42 fire-light42 merged commit 3f6dd01 into recloudstream:master Jan 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants