Support configuration cache for getting git commit #1494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be required in a future version of gradle so we may as well prepare for it and support it here. Without this: ``` Starting an external process 'git rev-parse --short HEAD' during configuration time is unsupported. ``` I am not sure if there is another solution here though but this is the only one I managed to get working.
This was referenced Jan 17, 2025
fire-light42
requested changes
Jan 18, 2025
fire-light42
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be required in a future version of gradle so we may as well prepare for it and support it here.
Without this:
I am not sure if there is another solution here though but this is the only one I managed to get working.
This combined with #1493 adds full support for configuration and build cache across cloudstream entirely.