feat(e2e): introduce e2e tests for bulk-import plugin#1972
Closed
AndrienkoAleksandr wants to merge 33 commits into
Closed
feat(e2e): introduce e2e tests for bulk-import plugin#1972AndrienkoAleksandr wants to merge 33 commits into
AndrienkoAleksandr wants to merge 33 commits into
Conversation
AndrienkoAleksandr
requested review from
a team,
debsmita1,
its-mitesh-kumar and
rm3l
as code owners
AndrienkoAleksandr
changed the title
AndrienkoAleksandr
force-pushed
the
add-bulk-import-e2e-tests
branch
from
430da43 to
3e959fc
Compare
gustavolira
approved these changes
Feb 25, 2026
github-actions
Bot
added
mandatory-workspace
AndrienkoAleksandr
force-pushed
the
add-bulk-import-e2e-tests
branch
from
3e959fc to
1fb6fa4
Compare
|
New changes are detected. LGTM label has been removed. |
Member
|
/test e2e-ocp-helm |
❌ Failed E2E Tests -
|
Member
|
/hold |
subhashkhileri
suggested changes
Mar 2, 2026
Contributor
Author
|
/test e2e-ocp-helm |
❌ Failed E2E Tests -
|
Contributor
Author
|
/test e2e-ocp-helm |
❌ Failed E2E Tests -
|
Contributor
Author
|
/publish |
Contributor
|
Publish workflow has completed with failure. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation❌ Found 2 validation error(s):
|
Contributor
Author
|
/publish |
Contributor
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
force-pushed
the
add-bulk-import-e2e-tests
branch
from
1cc8610 to
1ee6469
Compare
Contributor
Author
|
/publish |
Contributor
|
Publish workflow has completed with success. Publishing process✅ Finished successfully.
Backstage Compatibility Check✅ All workspaces are compatible with the target Backstage version ( No action required. Metadata Validation✅ All metadata files validated successfully. Running e2e tests |
Contributor
|
❌ Error logs from container |
❌ Failed E2E Tests -
|
PatAKnight
reviewed
May 19, 2026
| }); | ||
|
|
||
| test.beforeEach(async ({ loginHelper, uiHelper, page }) => { | ||
| await loginHelper.loginAsKeycloakUser(); |
Member
There was a problem hiding this comment.
Suggested change
| await loginHelper.loginAsKeycloakUser(); | |
| await loginHelper.loginAsGithubUser(); |
Instead of using Keycloak, why don't you use the native GitHub login helper. I believe it handles the 2fa for you and you shouldn't need the custom github auth code that you have under github-web-session.ts and github-oauth-app-helper.ts.
| await ensureGitHubOAuthAppForRhdh(namespace); | ||
| assertOAuthCredentialsPresent(); | ||
| await rhdh.configure({ | ||
| auth: options.auth ?? "keycloak", |
Member
There was a problem hiding this comment.
Suggested change
| auth: options.auth ?? "keycloak", | |
| auth: options.auth ?? "github", |
Same as the loginAsGithubUser suggestion
| }); | ||
|
|
||
| test.beforeEach(async ({ loginHelper, uiHelper, page }) => { | ||
| await loginAsKeycloakUserBulkImport( |
Member
There was a problem hiding this comment.
Could you not have used a guest user for this? Should be able to just add something like
auth:
environment: development
providers:
guest:
dangerouslyAllowOutsideDevelopment: trueto your app-config. And then just used loginAsGuest. After that you would just need to reject the GitHub pop up and then verify. Should allow you to remove some more of this custom logic
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
|
Contributor
Author
|
/test e2e-ocp-helm |
❌ Failed E2E Tests -
|
|
@AndrienkoAleksandr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Contributor
Author
|
Close on favor #2500 |
| "devDependencies": { | ||
| "@eslint/js": "^9.39.2", | ||
| "@playwright/test": "^1.56.1", | ||
| "@red-hat-developer-hub/e2e-test-utils": "1.1.32", |
Member
There was a problem hiding this comment.
This is a few versions behind (1.1.32) — latest is 1.1.43 and we're aligning everything in #2480. Could you pull that up before this merges?
Merged
3 tasks
Contributor
Author
|
Closing in favor of #2500. Thank you very much, @PatAKnight , for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do
Fixes: https://issues.redhat.com/browse/RHIDP-9350 and https://redhat.atlassian.net/browse/RHIDP-11360