feat(global-header): add mountpoints for default header components #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing ChangesetsThe following package(s) are changed by this PR but do not have a changeset:
See CONTRIBUTING.md for more information about how to add changesets. Changed Packages
|
ciiay
force-pushed
the
rhidp-5252-add-default-component-mountpoints
branch
2 times, most recently
from
977deae to
e423ed3
Compare
christoph-jerolimov
requested changes
Jan 28, 2025
workspaces/global-header/plugins/global-header/app-config.dynamic.yaml
Outdated
Show resolved
Hide resolved
...l-header/plugins/global-header/src/components/HeaderIconButtonComponent/HeaderIconButton.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
ciiay
force-pushed
the
rhidp-5252-add-default-component-mountpoints
branch
from
fcc3659 to
14b2884
Compare
|
4 tasks
|
Closing this PR in favor of #359 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
For RHIDP-5252
TODO:
add ErrorBoundary to each header componentupdate icon config solutioncomplete createDropdown and profileDropdown✔️ Checklist
Screen recording contains changes in rhdh PR, also see steps of testing from it.
rhidp_5252.mp4