feat(global-header): add mountpoints for default header components #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Packages
|
ciiay
force-pushed
the
rhidp-5255-extend-profile-dropdown
branch
from
f471444 to
9a38a27
Compare
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
Signed-off-by: Yi Cai <[email protected]>
ciiay
force-pushed
the
rhidp-5255-extend-profile-dropdown
branch
from
9a38a27 to
99bf3df
Compare
4 tasks
christoph-jerolimov
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
That's big! @ciiay 👍
Thanks a lot, also if I think we could maybe split some components, I think its great to have all this in and continue. Let's merge this. 👍
I'll just add a changeset to release it. :)
Signed-off-by: Christoph Jerolimov <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, I just made a Pull Request!
This PR is based off #328 changes. Open it when #328 gets merged.For RHIDP-5252, RHIDP-5254 and RHIDP-5255
✔️ Checklist
Screen recording contains changes in rhdh PR, also see steps of testing from it.
rhidp_5252.mp4