Skip to content

fix(bulk-import): fix French localization in Preview PR drawer#3327

Merged
ciiay merged 2 commits into
redhat-developer:mainfrom
its-mitesh-kumar:fix/bulk-import-french-pr-drawer-labels
Jun 9, 2026
Merged

fix(bulk-import): fix French localization in Preview PR drawer#3327
ciiay merged 2 commits into
redhat-developer:mainfrom
its-mitesh-kumar:fix/bulk-import-french-pr-drawer-labels

Conversation

@its-mitesh-kumar

Copy link
Copy Markdown
Member

Summary

  • Fixed the titleLabel French translation which used {{outil}} (French for "tool") instead of the correct interpolation variable {{tool}}, causing unresolved placeholder text in the Preview PR side drawer.
  • Improved French word order for titleLabel, bodyLabel, and details labels from English-style "{{tool}} noun" to natural French "Noun de {{tool}}".

Bug

RHDHBUGS-2206 — When French is selected as preferred language, some labels on the Preview PR side drawer display in {{outil}} format instead of the translated tool name.

UI before changes

test_1 8_French_localization_bug_1

UI after changes

S_ 2026-06-08 at 9 03 26 PM (2)

Changes

File: workspaces/bulk-import/plugins/bulk-import/src/translations/fr.ts

Key Before After
previewFile.pullRequest.titleLabel {{outil}} titre Titre de {{tool}}
previewFile.pullRequest.bodyLabel {{tool}} corps Corps de {{tool}}
previewFile.pullRequest.details {{tool}} détails Détails de {{tool}}

Test plan

  • Set preferred language to French in Settings
  • Navigate to Bulk Import, select a repository, and open the Preview PR side drawer
  • Verify the section heading shows "Détails de Demande d'extraction" (not {{outil}} or {{tool}})
  • Verify the title field label shows "Titre de Demande d'extraction"
  • Verify the body field label shows "Corps de Demande d'extraction"
  • Verify other languages (English, German, Spanish, Italian, Japanese) are unaffected

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

…labels

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@rhdh-gh-app

rhdh-gh-app Bot commented Jun 8, 2026

Copy link
Copy Markdown

Changed Packages

Package Name Package Path Changeset Bump Current Version
@red-hat-developer-hub/backstage-plugin-bulk-import workspaces/bulk-import/plugins/bulk-import patch v7.3.5

@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.98%. Comparing base (5bc0a03) to head (358f3f1).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3327   +/-   ##
=======================================
  Coverage   53.98%   53.98%           
=======================================
  Files        2401     2401           
  Lines       87397    87397           
  Branches    24196    24195    -1     
=======================================
  Hits        47179    47179           
  Misses      38670    38670           
  Partials     1548     1548           
Flag Coverage Δ *Carryforward flag
adoption-insights 83.58% <ø> (ø) Carriedforward from 3382240
ai-integrations 70.03% <ø> (ø) Carriedforward from 3382240
app-defaults 69.60% <ø> (ø) Carriedforward from 3382240
augment 46.39% <ø> (ø) Carriedforward from 3382240
bulk-import 72.86% <ø> (ø)
cost-management 17.48% <ø> (ø) Carriedforward from 3382240
dcm 59.64% <ø> (ø) Carriedforward from 3382240
extensions 62.24% <ø> (ø) Carriedforward from 3382240
global-floating-action-button 74.30% <ø> (ø) Carriedforward from 3382240
global-header 61.63% <ø> (ø) Carriedforward from 3382240
homepage 51.52% <ø> (ø) Carriedforward from 3382240
install-dynamic-plugins 56.23% <ø> (ø) Carriedforward from 3382240
konflux 91.01% <ø> (ø) Carriedforward from 3382240
lightspeed 68.47% <ø> (ø) Carriedforward from 3382240
mcp-integrations 85.46% <ø> (ø) Carriedforward from 3382240
orchestrator 37.33% <ø> (ø) Carriedforward from 3382240
quickstart 62.09% <ø> (ø) Carriedforward from 3382240
sandbox 79.42% <ø> (ø) Carriedforward from 3382240
scorecard 83.84% <ø> (ø) Carriedforward from 3382240
theme 64.54% <ø> (ø) Carriedforward from 3382240
translations 8.49% <ø> (ø) Carriedforward from 3382240
x2a 78.79% <ø> (ø) Carriedforward from 3382240

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bc0a03...358f3f1. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rohitratannagar rohitratannagar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Image

@ciiay ciiay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👏 The bug itself looks good to me. When I tested it out I found a small unrelated issue. The "Labels" placeholder are not localized for "se, fr, it, ja" and the placeholder text has a typo: the first "value2" should be "value1". Can we address this small issue in this PR?

Image

Also, make sure you test this on RHDH before merging, thanks 🤝

Signed-off-by: its-mitesh-kumar <itsmiteshkumar98@gmail.com>
@openshift-ci openshift-ci Bot removed the lgtm label Jun 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

@its-mitesh-kumar

Copy link
Copy Markdown
Member Author

Thanks for the PR 👏 The bug itself looks good to me. When I tested it out I found a small unrelated issue. The "Labels" placeholder are not localized for "se, fr, it, ja" and the placeholder text has a typo: the first "value2" should be "value1". Can we address this small issue in this PR?
Addressed

Before

S_.2026-06-09.at.7.49.16.PM.mov

After

S_.2026-06-09.at.9.19.04.PM.mov

@its-mitesh-kumar its-mitesh-kumar requested a review from ciiay June 9, 2026 16:17

@ciiay ciiay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Jun 9, 2026
@ciiay ciiay merged commit 0c4bc08 into redhat-developer:main Jun 9, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants