-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: catalog entity tabs order #2425
base: main
Are you sure you want to change the base?
fix: catalog entity tabs order #2425
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
41aa16f
to
4bfc660
Compare
Signed-off-by: its-mitesh-kumar <[email protected]>
Signed-off-by: its-mitesh-kumar <[email protected]>
The image is available at: |
@@ -13,3 +16,20 @@ export const hasAnnotation = (keys: string) => (entity: Entity) => | |||
|
|||
export const hasLinks = (entity: Entity) => | |||
Boolean(entity.metadata.links?.length); | |||
|
|||
export const mergeTabs = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this function used elsewhere in the app? I think hasLinks
and isType
have been put in this file because they're conditional functions that are leveraged by the config mapping.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this function is not used anywhere else. I moved it to utils to improve readability and keep the component cleaner and more maintainable. Let me know if you want it to move to component or some other new file .
@gashcrumb @debsmita1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you could create utils.tsx
under EntityPage and move the merge util there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: its-mitesh-kumar <[email protected]>
The image is available at: |
@its-mitesh-kumar: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixing RHIDP-5803
Description : With the fix user will be able to order entity tabs by providing
priority
and also they can hide any default tab by providing-ve
value aspriority
entity-tabs-order_Z5zxRutJ.mp4
For testing add below config in app-config.yaml
Try to play with priority