Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.5] fix: catalog entity tabs order #2523

Conversation

openshift-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #2425

/assign invincibleJai

Signed-off-by: its-mitesh-kumar <[email protected]>
Signed-off-by: its-mitesh-kumar <[email protected]>
Signed-off-by: its-mitesh-kumar <[email protected]>
Signed-off-by: its-mitesh-kumar <[email protected]>
Signed-off-by: its-mitesh-kumar <[email protected]>
Copy link

openshift-ci bot commented Mar 6, 2025

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@teknaS47
Copy link
Contributor

teknaS47 commented Mar 6, 2025

/ok-to-test

Copy link
Contributor

github-actions bot commented Mar 6, 2025

@its-mitesh-kumar
Copy link
Member

Tested on local with below config

    entity-tabs-customization:
      entityTabs:
        - path: "/pr"
          title: "Changed Pull/Merge Requests"
          priority: 1
          mountPoint: "entity.page.pull-requests"
        - path: "/"
          title: "Changed Overview"
          mountPoint: "entity.page.overview"
          priority: 6
        - path: "/api"
          title: "My Api"
          mountPoint: "entity.page.api"
          priority: 7
        - path: "/dependencies"
          title: "Ghor Dependecy"
          mountPoint: "entity.page.dependencies"
          priority: 5
Screenshot 2025-03-06 at 7 27 24 PM

@its-mitesh-kumar
Copy link
Member

/lgtm
/approve
Verified on cluster it's working as per expected with below configuration

entity-tabs-customization:
          entityTabs:
            - path: "/"
              title: "Changed Overview"
              mountPoint: "entity.page.overview"
              priority: 6
            - path: "/api"
              title: "My Api"
              mountPoint: "entity.page.api"
              priority: 7
            - path: "/dependencies"
              title: "Ghor Dependecy"
              mountPoint: "entity.page.dependencies"
              priority: 5
Screenshot 2025-03-06 at 7 50 22 PM

@teknaS47
Copy link
Contributor

teknaS47 commented Mar 6, 2025

/test e2e-tests

@teknaS47
Copy link
Contributor

teknaS47 commented Mar 6, 2025

/approve
Test on a cluster. Looks good to me

Copy link

openshift-ci bot commented Mar 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, its-mitesh-kumar, teknaS47

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 6, 2025
@invincibleJai
Copy link
Member

/retest

@nickboldt
Copy link
Member

@openshift-ci openshift-ci bot removed the lgtm label Mar 6, 2025
Copy link

openshift-ci bot commented Mar 6, 2025

New changes are detected. LGTM label has been removed.

@nickboldt nickboldt added the lgtm label Mar 6, 2025
Copy link
Contributor

github-actions bot commented Mar 6, 2025

@invincibleJai
Copy link
Member

/retest

1 similar comment
@invincibleJai
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 240de28 into redhat-developer:release-1.5 Mar 7, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants