Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): document auth via dynamic plugins #2446

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

gashcrumb
Copy link
Member

@gashcrumb gashcrumb commented Feb 25, 2025

Description

This change adds the configuration updates and examples related to installing and configuring authentication providers from dynamic plugins. This change also fixes a couple small markdown lint warnings.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

This change adds the configuration updates and examples related to
installing and configuring authentication providers from dynamic
plugins.  This change also fixes a couple small markdown lint warnings.

Signed-off-by: Stan Lewis <[email protected]>
@kadel
Copy link
Member

kadel commented Feb 25, 2025

no image build will be triggered as this is docs only PR
/override "Build Image"

/lgmt
/approve

Copy link

openshift-ci bot commented Feb 25, 2025

@kadel: Overrode contexts on behalf of kadel: Build Image

In response to this:

no image build will be triggered as this is docs only PR
/override "Build Image"

/lgmt
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kadel
Copy link
Member

kadel commented Feb 26, 2025

no image build will be triggered as this is docs only PR
/override "Build Image"

/lgmt
/approve

Copy link

openshift-ci bot commented Feb 26, 2025

@kadel: Overrode contexts on behalf of kadel: Build Image

In response to this:

no image build will be triggered as this is docs only PR
/override "Build Image"

/lgmt
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kadel
Copy link
Member

kadel commented Feb 26, 2025

/override "PR / Build with Node.js 20 (pull_request)"
/override "PR / Test with Node.js 20 (pull_request)"

no need to wait for tests for docs only PR

Copy link

openshift-ci bot commented Feb 26, 2025

@kadel: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • PR / Build with Node.js 20 (pull_request)
  • PR / Test with Node.js 20 (pull_request)

Only the following failed contexts/checkruns were expected:

  • Build Image
  • Build with Node.js 20
  • Test with Node.js 20

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "PR / Build with Node.js 20 (pull_request)"
/override "PR / Test with Node.js 20 (pull_request)"

no need to wait for tests for docs only PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kadel
Copy link
Member

kadel commented Feb 26, 2025

/override "Build with Node.js 20"
/override "Test with Node.js 20"

Copy link

openshift-ci bot commented Feb 26, 2025

@kadel: Overrode contexts on behalf of kadel: Build with Node.js 20, Test with Node.js 20

In response to this:

/override "Build with Node.js 20"
/override "Test with Node.js 20"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kadel
Copy link
Member

kadel commented Feb 26, 2025

/lgtm

Copy link

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kadel
Copy link
Member

kadel commented Feb 26, 2025

/refresh

@openshift-merge-bot openshift-merge-bot bot merged commit 176def0 into redhat-developer:main Feb 26, 2025
13 checks passed
@gashcrumb
Copy link
Member Author

/cherry-pick release-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@gashcrumb: new pull request created: #2467

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants