Skip to content

Drop support for Alpine Linux-specific version #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

datho7561
Copy link
Contributor

We can't build a binary version of the language server for Alpine Linux any more due to bugs/limitations in GraalVM and changes to the runners in GitHub Actions.

It's probably okay to drop Alpine Linux support, since Alpine Linux is usually used on servers instead of as a desktop operating system, and it's a real pain to set up as a desktop operating system.

Alpine Linux users should still be able to use the extension if they install Java.

@datho7561 datho7561 requested a review from rgrunber May 9, 2025 14:09
@datho7561
Copy link
Contributor Author

datho7561 commented May 9, 2025

Need to add an entry to the CHANGELOG done

@datho7561 datho7561 force-pushed the remove-alpine-from-build branch from 4d802db to 1ff7433 Compare May 9, 2025 14:14
@datho7561 datho7561 added this to the 0.29.0 milestone May 9, 2025
@datho7561 datho7561 added the build label May 9, 2025
@datho7561 datho7561 self-assigned this May 9, 2025
@datho7561 datho7561 moved this to Pending review in Java Tooling May 9, 2025
@datho7561 datho7561 force-pushed the remove-alpine-from-build branch from 1ff7433 to e41c2f3 Compare May 9, 2025 14:21
@datho7561 datho7561 changed the title Do not build Alpine Linux-specific version Drop support for Alpine Linux-specific version May 9, 2025
@datho7561 datho7561 requested a review from rgrunber May 9, 2025 14:21
@rgrunber
Copy link
Member

rgrunber commented May 9, 2025

/**
* Returns the platform of the current operating system.
* If the OS is Alpine Linux, it returns 'alpine'.
* Otherwise, it returns the platform string provided by the 'os' module.
*
* @returns The platform of the current operating system.
*/
function getPlatform (): NodeJS.Platform | 'alpine' {
return fs.existsSync('/etc/alpine-release') ? 'alpine' : os.platform();
}
mentions the path to the alpine binary, but if that's gonna be the linux one, then it should probably be removed ?

We can't build a binary version of the language server for Alpine Linux
any more due to bugs/limitations in GraalVM and changes to the runners
in GitHub Actions.

It's _probably_ okay to drop Alpine Linux support, since Alpine Linux
is usually used on servers instead of as a desktop operating system,
and it's a real pain to set up as a desktop operating system.

Alpine Linux users should still be able to use the extension if they
install Java.

Signed-off-by: David Thompson <[email protected]>
@datho7561 datho7561 force-pushed the remove-alpine-from-build branch from e41c2f3 to 5cb633e Compare May 9, 2025 14:40
@datho7561 datho7561 requested a review from rgrunber May 9, 2025 14:42
@datho7561 datho7561 merged commit e15a92c into redhat-developer:main May 9, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Pending review to Done in Java Tooling May 9, 2025
@datho7561 datho7561 deleted the remove-alpine-from-build branch May 9, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants