Skip to content

Remove ecoeng accounts, cluster policies from daily run#996

Merged
pragya811 merged 1 commit into
mainfrom
ecoeng-update2
May 11, 2026
Merged

Remove ecoeng accounts, cluster policies from daily run#996
pragya811 merged 1 commit into
mainfrom
ecoeng-update2

Conversation

@pragya811

@pragya811 pragya811 commented May 8, 2026

Copy link
Copy Markdown
Member

Type of change

Note: Fill x in []

  • bug
  • enhancement
  • documentation
  • dependencies

Description

  1. Remove ecoeng accounts from daily policies run:
  • certification-pipeline
  • coreos-training
  • partnerlab
  1. Move zombie_cluster_resources from dry_run 'no'

For security reasons, all pull requests need to be approved first before running any automated CI

Summary by CodeRabbit

  • Changes
    • zombie_cluster_resource policy no longer executes in non-dry-run mode
    • Removed multiple AWS accounts from daily policy execution workflow
  • Documentation
    • Updated policy configuration and account list documentation

@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown

Review Change Stack
No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 80363ea9-d6a7-4473-8879-1ac3157adfa2

📥 Commits

Reviewing files that changed from the base of the PR and between acdc4a3 and acb80d3.

📒 Files selected for processing (2)
  • jenkins/tenant/aws/ecoeng_01/PolicyJenkinsfileDaily
  • jenkins/tenant/aws/ecoeng_01/README.md

📝 Walkthrough

Walkthrough

This PR removes three AWS account entries (certification-pipeline, partnerlab, coreos-training) from the ecoeng_01 daily policy pipeline configuration and removes zombie_cluster_resource from the list of non-dry-run policies due to Hypershift incompatibility. The README documentation is updated to match these configuration changes.

Changes

ecoeng_01 Configuration Cleanup

Layer / File(s) Summary
Jenkins Pipeline Configuration
jenkins/tenant/aws/ecoeng_01/PolicyJenkinsfileDaily
Removes certification-pipeline, partnerlab, and coreos-training entries from accounts_list map. Removes zombie_cluster_resource from POLICIES_IN_ACTION JSON array.
Documentation Updates
jenkins/tenant/aws/ecoeng_01/README.md
Updates POLICIES_IN_ACTION list to exclude zombie_cluster_resource with note of dry-run-only status. Removes certification-pipeline and partnerlab entries from Accounts section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Three accounts hop away, one policy too,
Hypershift incompatibility—adieu!
Configuration cleaned, documentation aligned,
A tidier pipeline, configuration refined.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main changes: removing ecoeng accounts and cluster policies from daily runs, which aligns with the modifications to accounts_list and POLICIES_IN_ACTION.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ecoeng-update2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ebattat ebattat added the documentation Improvements or additions to documentation label May 8, 2026
@pragya811 pragya811 merged commit b300d18 into main May 11, 2026
19 checks passed
@pragya811 pragya811 deleted the ecoeng-update2 branch May 11, 2026 06:52
@github-project-automation github-project-automation Bot moved this from In progress to Done in Cloud-Governance project May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

Development

Successfully merging this pull request may close these issues.

3 participants