fix: replace keys() with search indexes to prevent Redis CrossSlot errors (#25) #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors (#25) Fixes #25 Replace all redis.keys() pattern matching calls with queries to prevent CROSSSLOT errors with Redis Cluster. Changes: - Replace keys() usage in base.py _load_pending_writes method - Replace keys() usage in aio.py _aload_pending_writes method - Replace keys() usage in __init__.py get_tuple method - Fix checkpoint_ns sentinel value handling for RediSearch tag fields - Fix type attribute access in get_channel_values method - Add proper type annotations and handle blob data encoding
There was a problem hiding this comment.
Pull Request Overview
This PR replaces all direct Redis keys() calls with RediSearch index queries to avoid CrossSlot errors, adjusts blob handling and type access, and adds end-to-end integration tests.
- Switch
keys()→FilterQueryin sync/async pending-writes loaders - Mirror search-index usage in
get_tuplefor blobs and writes, and tighten blob/type handling - Add
test_crossslot_integration.pyfor Redis Cluster scenarios
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/test_crossslot_integration.py | New integration tests to validate CrossSlot fixes |
| langgraph/checkpoint/redis/base.py | Use FilterQuery in _load_pending_writes, adjust sentinel usage |
| langgraph/checkpoint/redis/aio.py | Async counterpart: replace keys() with index search |
| langgraph/checkpoint/redis/init.py | Switch blob/write key lookups to index queries, fix blob deserialization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace all redis.keys() pattern matching calls with queries
to prevent CROSSSLOT errors with Redis Cluster.
Changes: