chore(tests): bump default docker test image to 8.8-rc1 + revert GCRA - #3284
Merged
Conversation
GCRA was removed from the Redis OSS 8.8 server image (8.8-rc1), so the client-side command and its example/registry entries are reverted. This reverts the GCRA additions from redis#3211.
nkaradzhov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
8.8-m03to8.8-rc1across the workflow matrix and all per-packagetest-utilsdefaults.Test plan
redislabs/client-libs-test:8.8-rc1Note
Medium Risk
Mostly test-infra changes, but it also removes the
GCRAcommand (and its tests/example), which can be a user-facing breaking change if it was relied on.Overview
Test infra update: switches the CI Redis matrix and all per-package
TestUtils.createFromConfigdefaults from8.8-m03to8.8-rc1.Feature removal: deletes the
GCRAcommand implementation and spec (packages/client/lib/commands/GCRA.ts/.spec.ts), removes it from the exported command index, and drops thegcra-rate-limiting.jsexample and its entry fromexamples/README.md.Reviewed by Cursor Bugbot for commit ab23b49. Bugbot is set up for automated code reviews on this repo. Configure here.