Skip to content

chore(tests): bump default docker test image to 8.8-rc1 + revert GCRA #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nkaradzhov merged 2 commits into from
May 19, 2026
Merged

chore(tests): bump default docker test image to 8.8-rc1 + revert GCRA #3284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f03e7cf
chore(tests): bump default docker test image to 8.8-rc1
nkaradzhov May 19, 2026
ab23b49
revert(client): remove GCRA ratelimit command
nkaradzhov May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ jobs:
version: "8.2"
- tag: "8.4.0"
version: "8.4"
- tag: "8.8-m03"
- tag: "8.8-rc1"
version: "8.8"
steps:
- uses: actions/checkout@v4
Expand Down
1 change: 0 additions & 1 deletion examples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ This folder contains example scripts showing how to use Node Redis in different
| `cuckoo-filter.js` | Space efficient set membership checks with a [Cuckoo Filter](https://en.wikipedia.org/wiki/Cuckoo_filter) using [RedisBloom](https://redisbloom.io). |
| `cas-cad-digest.js` | Atomic compare-and-set (CAS) and compare-and-delete (CAD) using digests for single-key optimistic concurrency control. |
| `dump-and-restore.js` | Demonstrates the use of the [`DUMP`](https://redis.io/commands/dump/) and [`RESTORE`](https://redis.io/commands/restore/) commands |
| `gcra-rate-limiting.js` | Demonstrates the [`GCRA`](https://redis.io/commands/gcra/) command for server-side rate limiting with optional token cost (`TOKENS`). |
| `get-server-time.js` | Get the time from the Redis server. |
| `hyperloglog.js` | Showing use of Hyperloglog commands [PFADD, PFCOUNT and PFMERGE](https://redis.io/commands/?group=hyperloglog). |
| `lua-multi-incr.js` | Define a custom lua script that allows you to perform INCRBY on multiple keys. |
Expand Down
29 changes: 0 additions & 29 deletions examples/gcra-rate-limiting.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/bloom/lib/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageTagArgument: 'redis-tag',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: { tag: '8.8-m03', version: '8.8' }
defaultDockerVersion: { tag: '8.8-rc1', version: '8.8' }
});

export const GLOBAL = {
Expand Down
77 changes: 0 additions & 77 deletions packages/client/lib/commands/GCRA.spec.ts
View file
Open in desktop

This file was deleted.

54 changes: 0 additions & 54 deletions packages/client/lib/commands/GCRA.ts
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions packages/client/lib/commands/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ import EVAL_RO from './EVAL_RO';
import EVAL from './EVAL';
import EVALSHA_RO from './EVALSHA_RO';
import EVALSHA from './EVALSHA';
import GCRA from './GCRA';
import GEOADD from './GEOADD';
import GEODIST from './GEODIST';
import GEOHASH from './GEOHASH';
Expand Down Expand Up @@ -1557,34 +1556,6 @@ export default {
* Returns information about the function that is currently running and information about the available execution engines
*/
functionStats: FUNCTION_STATS,
/**
* Rate limit via GCRA (Generic Cell Rate Algorithm).
* `tokensPerPeriod` are allowed per `period` at a sustained rate, which implies
* a minimum emission interval of `period / tokensPerPeriod` seconds between requests.
* `maxBurst` allows occasional spikes by permitting up to `maxBurst` additional
* tokens to be consumed at once.
* @param key - Key associated with the rate limit bucket
* @param maxBurst - Maximum number of extra tokens allowed as burst (min 0)
* @param tokensPerPeriod - Number of tokens allowed per period (min 1)
* @param period - Period in seconds as a float for sustained rate calculation (min 1.0, max 1e12)
* @param tokens - Optional request cost (weight). If omitted, defaults to 1
* @see https://redis.io/commands/gcra/
*/
GCRA,
/**
* Rate limit via GCRA (Generic Cell Rate Algorithm).
* `tokensPerPeriod` are allowed per `period` at a sustained rate, which implies
* a minimum emission interval of `period / tokensPerPeriod` seconds between requests.
* `maxBurst` allows occasional spikes by permitting up to `maxBurst` additional
* tokens to be consumed at once.
* @param key - Key associated with the rate limit bucket
* @param maxBurst - Maximum number of extra tokens allowed as burst (min 0)
* @param tokensPerPeriod - Number of tokens allowed per period (min 1)
* @param period - Period in seconds as a float for sustained rate calculation (min 1.0, max 1e12)
* @param tokens - Optional request cost (weight). If omitted, defaults to 1
* @see https://redis.io/commands/gcra/
*/
gcra: GCRA,
/**
* Adds geospatial items to the specified key
* @param key - Key to add the geospatial items to
Expand Down
2 changes: 1 addition & 1 deletion packages/client/lib/sentinel/test-util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ export class SentinelFramework extends DockerBase {
dockerImageName: 'redislabs/client-libs-test',
dockerImageTagArgument: 'redis-tag',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: { tag: '8.8-m03', version: '8.8' }
defaultDockerVersion: { tag: '8.8-rc1', version: '8.8' }
});
this.#nodeMap = new Map<string, ArrayElement<Awaited<ReturnType<SentinelFramework['spawnRedisSentinelNodes']>>>>();
this.#sentinelMap = new Map<string, ArrayElement<Awaited<ReturnType<SentinelFramework['spawnRedisSentinelSentinels']>>>>();
Expand Down
2 changes: 1 addition & 1 deletion packages/client/lib/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const utils = TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageTagArgument: 'redis-tag',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: { tag: '8.8-m03', version: '8.8' }
defaultDockerVersion: { tag: '8.8-rc1', version: '8.8' }
});

export default utils;
Expand Down
2 changes: 1 addition & 1 deletion packages/entraid/lib/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export const testUtils = TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageTagArgument: 'redis-tag',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: { tag: '8.8-m03', version: '8.8' }
defaultDockerVersion: { tag: '8.8-rc1', version: '8.8' }
});

const DEBUG_MODE_ARGS = testUtils.isVersionGreaterThan([7]) ?
Expand Down
2 changes: 1 addition & 1 deletion packages/json/lib/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageTagArgument: 'redis-tag',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: { tag: '8.8-m03', version: '8.8' }
defaultDockerVersion: { tag: '8.8-rc1', version: '8.8' }
});

export const GLOBAL = {
Expand Down
2 changes: 1 addition & 1 deletion packages/search/lib/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageTagArgument: 'redis-tag',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: { tag: '8.8-m03', version: '8.8' }
defaultDockerVersion: { tag: '8.8-rc1', version: '8.8' }
});

export const GLOBAL = {
Expand Down
2 changes: 1 addition & 1 deletion packages/test-utils/lib/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export const testUtils = TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageTagArgument: 'redis-tag',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: { tag: '8.8-m03', version: '8.8' }
defaultDockerVersion: { tag: '8.8-rc1', version: '8.8' }
});


Expand Down
2 changes: 1 addition & 1 deletion packages/time-series/lib/test-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export default TestUtils.createFromConfig({
dockerImageName: 'redislabs/client-libs-test',
dockerImageTagArgument: 'redis-tag',
dockerImageVersionArgument: 'redis-version',
defaultDockerVersion: { tag: '8.8-m03', version: '8.8' }
defaultDockerVersion: { tag: '8.8-rc1', version: '8.8' }
});

export const GLOBAL = {
Expand Down
Loading