#421: Step Goal - Property naming fixes - #67
Merged
Conversation
…altemplate.property.steps..question.name` and `goaltemplate.property.steps.goal..singleChoiceState.name`. Those are removed now
iaigner
reviewed
Jul 8, 2026
| CONFIG_SECTION_SELF_REPORT, | ||
| new StringValue("question") | ||
| .setName(STEP_PROPERTY_PREFIX + ".question.name") | ||
| .setName(STEP_PROPERTY_PREFIX + "question.name") |
There was a problem hiding this comment.
.goal.question.name
-> sofern du das nicht im prefix hast. sonst stimmts nicht überein
Member
Author
There was a problem hiding this comment.
ne das goal ist nicht im prefix. Das muss ich dann aber zu 3 properties hinzufügen
| new StringValue("question") | ||
| .setName(STEP_PROPERTY_PREFIX + ".question.name") | ||
| .setName(STEP_PROPERTY_PREFIX + "question.name") | ||
| .setDescription(STEP_PROPERTY_PREFIX + "question.description") |
| .setRequired(false), | ||
| new BooleanValue("singleChoiceState") | ||
| .setName(STEP_PROPERTY_PREFIX + ".singleChoiceState.name") | ||
| .setName(STEP_PROPERTY_PREFIX + "singlFeChoiceState.name") |
There was a problem hiding this comment.
.goal.singleChoiceState.name
-> da hat sich auch ein F eingeschlichen
| new BooleanValue("singleChoiceState") | ||
| .setName(STEP_PROPERTY_PREFIX + ".singleChoiceState.name") | ||
| .setName(STEP_PROPERTY_PREFIX + "singlFeChoiceState.name") | ||
| .setDescription(STEP_PROPERTY_PREFIX + "singleChoiceState.description") |
iaigner
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MORE-Platform#421: two properties used multiple points in its key
goaltemplate.property.steps..question.nameandgoaltemplate.property.steps.goal..singleChoiceState.name. Those are removed now