Skip to content

#421: Step Goal - Property naming fixes #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westei merged 3 commits into from
Jul 8, 2026
Merged

#421: Step Goal - Property naming fixes #67

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
acb18cb
#421: two properties used multiple points in its key `goaltemplate.pr…
Jul 8, 2026
8451b1b
#421: fixed an typo
Jul 8, 2026
4eba664
#421: added `goal.` to properties where missing
Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...ain/java/io/redlink/more/studymanager/component/goaltemplate/StepGoalTemplateFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ public List<Value> getProperties() {

CONFIG_SECTION_SELF_REPORT,
new StringValue("question")
.setName(STEP_PROPERTY_PREFIX + ".question.name")
.setName(STEP_PROPERTY_PREFIX + "question.name")

@iaigner iaigner Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.goal.question.name
-> sofern du das nicht im prefix hast. sonst stimmts nicht überein

@westei westei Jul 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ne das goal ist nicht im prefix. Das muss ich dann aber zu 3 properties hinzufügen

.setDescription(STEP_PROPERTY_PREFIX + "question.description")

@iaigner iaigner Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.goal.question.description

.setRequired(false),
new StringListValue("answers")
Expand All @@ -94,7 +94,7 @@ public List<Value> getProperties() {
))
.setRequired(false),
new BooleanValue("singleChoiceState")
.setName(STEP_PROPERTY_PREFIX + ".singleChoiceState.name")
.setName(STEP_PROPERTY_PREFIX + "singlFeChoiceState.name")

@iaigner iaigner Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.goal.singleChoiceState.name
-> da hat sich auch ein F eingeschlichen

.setDescription(STEP_PROPERTY_PREFIX + "singleChoiceState.description")

@iaigner iaigner Jul 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.goal.singleChoiceState.description

.setRequired(false)
);
Expand Down
Loading