Add cleanup method; add support for merged metric files collection#1
Open
agoncharov-reef wants to merge 2 commits intomasterfrom
Open
Add cleanup method; add support for merged metric files collection#1agoncharov-reef wants to merge 2 commits intomasterfrom
agoncharov-reef wants to merge 2 commits intomasterfrom
Conversation
Collaborator
Author
|
@copilot Check this stuff and make it so nice that everybody immediately wants to raise my salary. |
7 tasks
|
@agoncharov-reef I've opened a new pull request, #2, to work on those changes. Once the pull request is ready, I'll request review from you. |
Collaborator
Author
|
Mf, you should've made it pretty, not show all my ugly mistakes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usually built-in
mark_process_dead()removes stale*.dbmetrics files. However, there are cases when it doesn't happen (for example, celery worker dies), and stale files are left. We want to collect & collapse them.*.dbfile, we acquire advisory lock (flock).merged_metrics.pkl. If the latter already exists, we combine results with it, too.*.dbfiles but also readmerged_metrics.pkland merge everything and then output it.