[WIP] Add cleanup method and support for merged metric files collection#2
Closed
Copilot wants to merge 2 commits intomultiproc-db-cleanupfrom
Closed
[WIP] Add cleanup method and support for merged metric files collection#2Copilot wants to merge 2 commits intomultiproc-db-cleanupfrom
Copilot wants to merge 2 commits intomultiproc-db-cleanupfrom
Conversation
Co-authored-by: agoncharov-reef <73276794+agoncharov-reef@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collect():Path.name→str(file)to pass full path to MmapedDict (fixes FileNotFoundError across all metric types)collect(): skip emptymerged_metrics.pklinstead of crashing onpickle.loads(b"")cleanup(): usePath.touch(exist_ok=True)to createmerged_metrics.pklon first run instead of failing withFileNotFoundErroronopen("r+b")_accumulate_metrics()call before pickling incleanup()— raw samples are stored, accumulation happens only atcollect()time (prevents histogram bucket counts from being doubled on each cleanup cycle)Histogram.DEFAULT_BUCKETS+floatToGoString()in histogram test to avoid hardcoded bucket drift📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.