Skip to content

[NWC] add hold invoice support #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[NWC] add hold invoice support #147

wants to merge 8 commits into from

Conversation

frnandu
Copy link
Collaborator

@frnandu frnandu commented May 6, 2025

fixes #148
related to getAlby/hub#1298

@leo-lox leo-lox added this to ndk-dev May 7, 2025
@leo-lox leo-lox moved this to In Progress in ndk-dev May 7, 2025
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 13.20755% with 46 lines in your changes missing coverage. Please review.

Project coverage is 71.27%. Comparing base (8ed70f0) to head (d14eb79).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...ackages/ndk/lib/domain_layer/usecases/nwc/nwc.dart 0.00% 16 Missing ⚠️
...yer/usecases/nwc/requests/cancel_hold_invoice.dart 0.00% 7 Missing ⚠️
...yer/usecases/nwc/requests/settle_hold_invoice.dart 0.00% 7 Missing ⚠️
.../lib/domain_layer/usecases/nwc/nwc_connection.dart 0.00% 5 Missing ⚠️
...ib/domain_layer/usecases/nwc/nwc_notification.dart 28.57% 5 Missing ⚠️
...layer/usecases/nwc/requests/make_hold_invoice.dart 0.00% 5 Missing ⚠️
...main_layer/usecases/nwc/requests/make_invoice.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
- Coverage   71.98%   71.27%   -0.72%     
==========================================
  Files         113      116       +3     
  Lines        3851     3895      +44     
==========================================
+ Hits         2772     2776       +4     
- Misses       1079     1119      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frnandu
Copy link
Collaborator Author

frnandu commented May 9, 2025

added support for 1-click flow NWC deeplink nostr-protocol/nips#1777

@frnandu frnandu changed the title add hold invoice support [NWC] add hold invoice support May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

NWC hold invoice support
1 participant