Conversation
Collaborator
Author
|
@lslebodn @ashwini3326 PTAL |
lslebodn
reviewed
May 29, 2025
lslebodn
reviewed
May 29, 2025
JAVGan
force-pushed
the
core_sas
branch
3 times, most recently
from
bfe9cf5 to
f11d1c0
Compare
This was referenced May 29, 2025
JAVGan
force-pushed
the
core_sas
branch
3 times, most recently
from
d0c6f7f to
9c5801a
Compare
Collaborator
Author
JAVGan
force-pushed
the
core_sas
branch
3 times, most recently
from
09df1f0 to
cafe980
Compare
This commit introduces a new feature for the `AzureProvider` based on CloudPub v1.4.0: The ability to compare SAS URIs without their parameters for `coreVirtualMachine` types. It will perform a base SAS URI comparison whenever the `StArMap` mappings contains `'check_base_sas_only': True` in its destination. Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
Collaborator
Author
|
@lslebodn ready to review now 😄 |
lslebodn
approved these changes
May 30, 2025
lslebodn
left a comment
lslebodn
left a comment
Collaborator
There was a problem hiding this comment.
simple and thus also very nice
ACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new feature for the
AzureProviderbased on CloudPub v1.4.0: The ability to compare SAS URIs without their parameters forcoreVirtualMachinetypes.It will perform a base SAS URI comparison whenever the
StArMapmappings contains
'check_base_sas_only': Truein its destination.