Skip to content

Add new optional attribute for Destination#93

Merged
JAVGan merged 1 commit into
mainfrom
check_base_sas_only
May 29, 2025
Merged

Add new optional attribute for Destination#93
JAVGan merged 1 commit into
mainfrom
check_base_sas_only

Conversation

@JAVGan

@JAVGan JAVGan commented May 29, 2025

Copy link
Copy Markdown
Collaborator

This commit introduces a the new attribute vhd_check_base_sas_only for Destination which will be used to inform whether to perform a base SAS check only on VHD images or not (full SAS comparison).

@JAVGan JAVGan requested review from jajreidy and lslebodn as code owners May 29, 2025 19:55
@JAVGan

JAVGan commented May 29, 2025

Copy link
Copy Markdown
Collaborator Author

@lslebodn this one relates to release-engineering/pubtools-marketplacesvm#107

If you're good with it I'll just need to patch the StArMap server as well.

This commit introduces a the new attribute `vhd_check_base_sas_only` for
`Destination` which will be used to inform whether to perform a base SAS
check only on VHD images or not (full SAS comparison).

Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
@JAVGan JAVGan force-pushed the check_base_sas_only branch from 77ae3d1 to c1026e6 Compare May 29, 2025 20:02

@lslebodn lslebodn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JAVGan JAVGan merged commit b907725 into main May 29, 2025
23 checks passed
@JAVGan JAVGan deleted the check_base_sas_only branch May 29, 2025 20:43
JAVGan added a commit that referenced this pull request May 29, 2025
Changes:
  - Add new optional attribute for Destination #93
  - Bump dependencies

Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
@JAVGan JAVGan mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants