fix(ui): body should not be scrollable when opening pomodoro settings #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First and foremost, thanks for keeping moodist free!
I noticed that opening the Pomodoro Settings Modal made the body scrollable: this is probably caused by the
else ifcondition in the firstuseEffectof the Pomodoro main Modal.The Modal rendered by the Settings component has
lockBody={false}so it seems like there is already an intention to prevent this "secondary" modal to influence the body scroll functionality, but as of right now it also closes the main modal which haslockBody={true}.I think that a simple fix is keeping the main modal open: we lose its animations when opening/closing the settings but it should be fine for the UX since we are still in the "Pomodoro application context".
Let me know if there are any problems regarding this PR!