Skip to content

fix(ui): body should not be scrollable when opening pomodoro settings #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkzxc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): body should not be scrollable when opening pomodoro settings #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/components/toolbar/menu/menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,7 @@ export function Menu() {
show={modals.shortcuts}
onClose={() => close('shortcuts')}
/>
<Pomodoro
open={() => open('pomodoro')}
show={modals.pomodoro}
onClose={() => close('pomodoro')}
/>
<Pomodoro show={modals.pomodoro} onClose={() => close('pomodoro')} />
<Notepad show={modals.notepad} onClose={() => close('notepad')} />
<Todo show={modals.todo} onClose={() => close('todo')} />
<Countdown show={modals.countdown} onClose={() => close('countdown')} />
Expand Down
6 changes: 1 addition & 5 deletions src/components/toolbox/pomodoro/pomodoro.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,10 @@ import styles from './pomodoro.module.css';

interface PomodoroProps {
onClose: () => void;
open: () => void;
show: boolean;
}

export function Pomodoro({ onClose, open, show }: PomodoroProps) {
export function Pomodoro({ onClose, show }: PomodoroProps) {
const [showSetting, setShowSetting] = useState(false);

const [selectedTab, setSelectedTab] = useState('pomodoro');
Expand Down Expand Up @@ -130,7 +129,6 @@ export function Pomodoro({ onClose, open, show }: PomodoroProps) {
icon={<IoMdSettings />}
tooltip="Change Times"
onClick={() => {
onClose();
setShowSetting(true);
}}
/>
Expand Down Expand Up @@ -167,11 +165,9 @@ export function Pomodoro({ onClose, open, show }: PomodoroProps) {
onChange={times => {
setShowSetting(false);
setTimes(times);
open();
}}
onClose={() => {
setShowSetting(false);
open();
}}
/>
</>
Expand Down