-
Notifications
You must be signed in to change notification settings - Fork 447
Improve 2D heuristic fallback values for image opacity #9787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
So, this is annoying. I noticed some snapshot tests were failing, and after updating them, now they're failing on CI. But looking at the differences, there really aren't any. Not sure what to do here. |
@@ -205,8 +207,21 @@ impl EncodedImageVisualizer { | |||
} | |||
|
|||
impl TypedComponentFallbackProvider<Opacity> for EncodedImageVisualizer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be the same for VideoVisualizer then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Emil is right that we should also add this to the video visualizer just the same! Please do so before merging, thx!
The image comparision changes are strange indeed! Have you checked the diff images that were changed on ci? Ci generates a zip with before/after/diff images
Is it maybe an LFS issue (before/after not being lfs)? (doesn't look like though, it says 4 lines changed for the diff)
Yes. There is some difference between how it renders on my machine and CI. Is there a chance that it's different llvmpipe versions, or maybe it isn't software rendering on my end? |
No change that I'm aware of, no I'll have a poke later today! |
It looks like video doesn't support |
Opened an issue for that and linked it in a comment: |
Decided to revert the snapshot to what's on CI for the time being |
which is proving to be a mistake, because now I'll have to wait for CI to report all the sequential failures one by one... |
thanks! |
don't merge this yet, i left some (it was supposed to be temporary, but i think it's fine to leave it in) |
Latest documentation preview deployed successfully.
Note: This comment is updated whenever you push a commit. |
(my fault, forgot to invert the condition) |
Previously, only segmentation images had an opacity fallback of
0.5
when other non-segmentation images were in the same view. We now keep track of the number of images per image kind, and use that to determine what the opacity should be for all image kinds that support opacity.The images further to the front will be transparent if there are images possibly behind them.
Assuming the draw order fallback is also used, the draw order will be (front to back):
Examples of fallback opacity: