Use ComponentDescriptor in HybridLatestAtResult
#9938
Conversation
Actually, `re_view_dataframe` still uses `ComponentNameSet`
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
| @@ -79,15 +79,15 @@ impl ContainerBlueprint { | |||
| // This is a required component. Note that when loading containers we crawl the subtree and so | |||
| // cleared empty container paths may exist transiently. The fact that they have an empty container_kind | |||
| // is the marker that the have been cleared and not an error. | |||
| let container_kind = results.component_instance::<ContainerKind>(0)?; | |||
| let container_kind = results.component_mono::<ContainerKind>()?; | |||
There was a problem hiding this comment.
Can we use component_instance and component_mono interchangeably?
There was a problem hiding this comment.
IIRC the difference is that some (.. not the ones here I figure) component_mono implementations also will check whether a component was truly mono and allow you to issue a warning
grtlr
added
exclude from changelog
| @@ -41,14 +41,19 @@ pub struct HybridRangeResults<'a> { | |||
| impl HybridLatestAtResults<'_> { | |||
| /// Returns the [`UnitChunkShared`] for the specified [`re_types_core::Component`]. | |||
| #[inline] | |||
| pub fn get(&self, component_name: impl Into<ComponentName>) -> Option<&UnitChunkShared> { | |||
| // TODO(#6889): This method seems to be unused? | |||
There was a problem hiding this comment.
yes, please! :)
the get_by_name on LatestAtResults says it wants to be removed -> you have to remove this one ;-)
grtlr
force-pushed
the
grtlr/hybrid-latest-at-tagged
branch
from
90a4af1 to
99bd5f8
Compare
grtlr
changed the base branch from
main
to
andreas/remove-various-non-tag-crutches
grtlr
changed the base branch from
andreas/remove-various-non-tag-crutches
to
main
| let component_name = component_name.into(); | ||
| self.overrides | ||
| .get_by_name(&component_name) | ||
| .or_else(|| self.results.get_by_name(&component_name)) | ||
| .or_else(|| self.defaults.get_by_name(&component_name)) | ||
| } | ||
|
|
||
| // TODO(#6889): Right now, fallbacks are on a per-component basis, so it's fine to pass the component name here. |
There was a problem hiding this comment.
added to the list of things to do on that ticket
| @@ -79,15 +79,15 @@ impl ContainerBlueprint { | |||
| // This is a required component. Note that when loading containers we crawl the subtree and so | |||
| // cleared empty container paths may exist transiently. The fact that they have an empty container_kind | |||
| // is the marker that the have been cleared and not an error. | |||
| let container_kind = results.component_instance::<ContainerKind>(0)?; | |||
| let container_kind = results.component_mono::<ContainerKind>()?; | |||
There was a problem hiding this comment.
IIRC the difference is that some (.. not the ones here I figure) component_mono implementations also will check whether a component was truly mono and allow you to issue a warning
Related
MaybeTaggedaccessor utility #9929.What
Title.