Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: update package-lock.json files #7298

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: update package-lock.json files #7298

wants to merge 1 commit into from

Conversation

aspeddro
Copy link
Contributor

Changes found after running make test-all

@cknitt
Copy link
Member

cknitt commented Feb 16, 2025

@aspeddro Thanks! Could you also update scripts/setVersion.js accordingly? Then this would happen automatically whenever I bump the version number.

@aspeddro aspeddro marked this pull request as draft February 17, 2025 16:25
@aspeddro aspeddro force-pushed the tests-changes-not-updated branch from f479de9 to ebbb8be Compare March 22, 2025 00:40
@aspeddro aspeddro force-pushed the tests-changes-not-updated branch from cf92d96 to e64cff8 Compare March 22, 2025 01:39
@aspeddro
Copy link
Contributor Author

I find it easier to do a cleanup and run the tests again.

  1. node scripts/setVersion.js
  2. make clean clean-gentype (ignore rewatch)
  3. make test-all

All lock files will be updated

@aspeddro aspeddro changed the title tests: update package-lock.json tests: update package-lock.json files Mar 22, 2025
@aspeddro aspeddro marked this pull request as ready for review March 22, 2025 01:43
@cometkim
Copy link
Member

Thanks, I'll make a CI workflow to check this kind of changes

@cometkim cometkim self-requested a review March 22, 2025 17:04
@cometkim cometkim requested a review from cknitt March 22, 2025 17:05
@cometkim
Copy link
Member

Or maybe we can just make it as workspaces so lockfiles can be merged for entire project.

@aspeddro
Copy link
Contributor Author

Thanks, I'll make a CI workflow to check this kind of changes

I tried to check on CI but the lock files change when running npm install

@cometkim cometkim mentioned this pull request Mar 22, 2025
Closed
@cometkim
Copy link
Member

#7356

@cometkim cometkim mentioned this pull request Mar 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cometkim cometkim cometkim approved these changes

@cknitt cknitt Awaiting requested review from cknitt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aspeddro @cknitt @cometkim