hotfix/on resize issue#873
Conversation
|
@codex review |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
WalkthroughThis PR fixes viewport resize behavior by ensuring scroll service parameters are synchronized when viewport dimensions change, while preventing memory leaks from pending throttled resize callbacks. An e2e test validates the grid remains properly scrolled after resize operations. ChangesViewport Resize and Scroll Synchronization
Submodule Updates
Sequence DiagramsequenceDiagram
participant GridResizeService
participant RevogrViewportScroll
participant LocalScrollService
GridResizeService->>RevogrViewportScroll: emit resize update with new sizes
RevogrViewportScroll->>RevogrViewportScroll: calculate rgRow/rgCol from viewport
RevogrViewportScroll->>LocalScrollService: setScrollParams with new client sizes
RevogrViewportScroll->>RevogrViewportScroll: recalculate scroll visibility
RevogrViewportScroll->>RevogrViewportScroll: emit per-dimension resize events
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |



Summary by CodeRabbit
Bug Fixes
Tests
Chores