Set bluefield-ocp container registry address#72
Set bluefield-ocp container registry address#72eelgaev wants to merge 1 commit intorh-ecosystem-edge:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eelgaev The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughUpdated the default container registry reference for the BlueField OCP layer from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@api/v1alpha1/dpfhcpprovisionerconfig_types.go`:
- Around line 28-33: The BlueFieldOCPLayerRepo field currently points to
"quay.io/edge-infrastructure/bluefield-ocp" which lacks several OCP tags (e.g.,
4.20.x, 4.21.6, 4.22.0-ec.x) and will cause runtime failures when the operator
cannot find matching images; either populate the new registry with the missing
tags, explicitly document supported/dropped OCP versions in the TODO comment, or
revert/point BlueFieldOCPLayerRepo to a registry that contains the full tag
set—update the struct field comment and the TODO near BlueFieldOCPLayerRepo to
state which OCP versions are supported or that the registry is incomplete so
reviewers and operators know the limitation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 17071e62-1827-429e-9fb9-4c1a376fc398
📒 Files selected for processing (6)
README.mdapi/v1alpha1/dpfhcpprovisionerconfig_types.goconfig/crd/bases/provisioning.dpu.hcp.io_dpfhcpprovisionerconfigs.yamldocs/configuration.mdhelm/dpf-hcp-provisioner-operator/templates/dpfhcpprovisionerconfig.yamltest/e2e/README.md
| // BlueFieldOCPLayerRepo is the container registry repository for BlueField OCP layer images. | ||
| // The operator queries this repository to find an image tag matching the OCP version. | ||
| // TODO: Replace with the official registry once we have one | ||
| // +kubebuilder:default="quay.io/eelgaev/rhcos-bfb" | ||
| // +kubebuilder:default="quay.io/edge-infrastructure/bluefield-ocp" | ||
| // +optional | ||
| BlueFieldOCPLayerRepo string `json:"blueFieldOCPLayerRepo,omitempty"` |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify the new BlueField OCP registry is accessible and list available tags
# Check if the registry repository exists and list tags
echo "Checking registry: quay.io/edge-infrastructure/bluefield-ocp"
curl -s "https://quay.io/api/v1/repository/edge-infrastructure/bluefield-ocp/tag/" | jq -r '.tags[]? | select(.name) | .name' | head -20
# Compare with old registry
echo -e "\n---\nChecking old registry: quay.io/eelgaev/rhcos-bfb"
curl -s "https://quay.io/api/v1/repository/eelgaev/rhcos-bfb/tag/" | jq -r '.tags[]? | select(.name) | .name' | head -20Repository: rh-ecosystem-edge/dpf-hcp-provisioner-operator
Length of output: 534
The new registry has incomplete tag coverage; missing tags from the old registry may cause runtime failures.
While quay.io/edge-infrastructure/bluefield-ocp is accessible and contains OCP version tags, it lacks versions available in the previous registry:
- Missing 4.20.x series (4.20.4, 4.20.4-64k)
- Missing 4.21.6
- Missing 4.22.0-ec versions (4.22.0-ec.2, 4.22.0-ec.3-rhel10)
This means the operator will fail to find images for any OCP version not in the 4.21.0–4.21.8 range. Before merging, either:
- Ensure all required OCP version tags are added to the new registry
- Clarify that support for 4.20.x and 4.22.0-ec.x versions is intentionally dropped
- Update the TODO comment to reflect the official registry status
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@api/v1alpha1/dpfhcpprovisionerconfig_types.go` around lines 28 - 33, The
BlueFieldOCPLayerRepo field currently points to
"quay.io/edge-infrastructure/bluefield-ocp" which lacks several OCP tags (e.g.,
4.20.x, 4.21.6, 4.22.0-ec.x) and will cause runtime failures when the operator
cannot find matching images; either populate the new registry with the missing
tags, explicitly document supported/dropped OCP versions in the TODO comment, or
revert/point BlueFieldOCPLayerRepo to a registry that contains the full tag
set—update the struct field comment and the TODO near BlueFieldOCPLayerRepo to
state which OCP versions are supported or that the registry is incomplete so
reviewers and operators know the limitation.
|
Converted back to draft, builds are not stable. |
1 participant
Summary by CodeRabbit
quay.io/eelgaev/rhcos-bfbtoquay.io/edge-infrastructure/bluefield-ocpacross configuration, deployment templates, and test environments.