Skip to content

Set bluefield-ocp container registry address #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
eelgaev wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Set bluefield-ocp container registry address #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,15 +116,15 @@ A cluster-scoped singleton (must be named `default`) that provides operator-wide

| Field | Type | Default | Description |
|-------|------|---------|------------------------------------------------------------------|
| `blueFieldOCPLayerRepo` | `string` | `quay.io/eelgaev/rhcos-bfb` | Container registry for BlueField OCP layer images |
| `blueFieldOCPLayerRepo` | `string` | `quay.io/edge-infrastructure/bluefield-ocp` | Container registry for BlueField OCP layer images |

```yaml
apiVersion: provisioning.dpu.hcp.io/v1alpha1
kind: DPFHCPProvisionerConfig
metadata:
name: default
spec:
blueFieldOCPLayerRepo: quay.io/eelgaev/rhcos-bfb
blueFieldOCPLayerRepo: quay.io/edge-infrastructure/bluefield-ocp
```

## Deployment
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/dpfhcpprovisionerconfig_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ type DPFHCPProvisionerConfigSpec struct {
// BlueFieldOCPLayerRepo is the container registry repository for BlueField OCP layer images.
// The operator queries this repository to find an image tag matching the OCP version.
// TODO: Replace with the official registry once we have one
// +kubebuilder:default="quay.io/eelgaev/rhcos-bfb"
// +kubebuilder:default="quay.io/edge-infrastructure/bluefield-ocp"
// +optional
BlueFieldOCPLayerRepo string `json:"blueFieldOCPLayerRepo,omitempty"`
Comment on lines 28 to 33
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the new BlueField OCP registry is accessible and list available tags

# Check if the registry repository exists and list tags
echo "Checking registry: quay.io/edge-infrastructure/bluefield-ocp"
curl -s "https://quay.io/api/v1/repository/edge-infrastructure/bluefield-ocp/tag/" | jq -r '.tags[]? | select(.name) | .name' | head -20

# Compare with old registry
echo -e "\n---\nChecking old registry: quay.io/eelgaev/rhcos-bfb"
curl -s "https://quay.io/api/v1/repository/eelgaev/rhcos-bfb/tag/" | jq -r '.tags[]? | select(.name) | .name' | head -20

Repository: rh-ecosystem-edge/dpf-hcp-provisioner-operator

Length of output: 534

The new registry has incomplete tag coverage; missing tags from the old registry may cause runtime failures.

While quay.io/edge-infrastructure/bluefield-ocp is accessible and contains OCP version tags, it lacks versions available in the previous registry:

  • Missing 4.20.x series (4.20.4, 4.20.4-64k)
  • Missing 4.21.6
  • Missing 4.22.0-ec versions (4.22.0-ec.2, 4.22.0-ec.3-rhel10)

This means the operator will fail to find images for any OCP version not in the 4.21.0–4.21.8 range. Before merging, either:

  1. Ensure all required OCP version tags are added to the new registry
  2. Clarify that support for 4.20.x and 4.22.0-ec.x versions is intentionally dropped
  3. Update the TODO comment to reflect the official registry status
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@api/v1alpha1/dpfhcpprovisionerconfig_types.go` around lines 28 - 33, The
BlueFieldOCPLayerRepo field currently points to
"quay.io/edge-infrastructure/bluefield-ocp" which lacks several OCP tags (e.g.,
4.20.x, 4.21.6, 4.22.0-ec.x) and will cause runtime failures when the operator
cannot find matching images; either populate the new registry with the missing
tags, explicitly document supported/dropped OCP versions in the TODO comment, or
revert/point BlueFieldOCPLayerRepo to a registry that contains the full tag
set—update the struct field comment and the TODO near BlueFieldOCPLayerRepo to
state which OCP versions are supported or that the registry is incomplete so
reviewers and operators know the limitation.

}
Expand Down
2 changes: 1 addition & 1 deletion config/crd/bases/provisioning.dpu.hcp.io_dpfhcpprovisionerconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ spec:
description: DPFHCPProvisionerConfigSpec defines the operator-wide configuration
properties:
blueFieldOCPLayerRepo:
default: quay.io/eelgaev/rhcos-bfb
default: quay.io/edge-infrastructure/bluefield-ocp
description: |-
BlueFieldOCPLayerRepo is the container registry repository for BlueField OCP layer images.
The operator queries this repository to find an image tag matching the OCP version.
Expand Down
4 changes: 2 additions & 2 deletions docs/configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,14 +94,14 @@ The `DPFHCPProvisionerConfig` is a cluster-scoped singleton CR that controls ope
The Helm chart automatically creates this CR with default values. You can customize it post-deployment:

```bash
kubectl patch dpfhcpconfig default --type merge -p '{"spec":{"blueFieldOCPLayerRepo":"quay.io/eelgaev/rhcos-bfb"}}'
kubectl patch dpfhcpconfig default --type merge -p '{"spec":{"blueFieldOCPLayerRepo":"quay.io/edge-infrastructure/bluefield-ocp"}}'
```

### Fields

| Field | Type | Default | Description |
|-------|------|---------|-------------|
| `spec.blueFieldOCPLayerRepo` | `string` | `quay.io/eelgaev/rhcos-bfb` | Container registry repository for BlueField RHCOS OCP image layers. The operator queries this repo to find an image tag matching the OCP version. The lookup is skipped when `machineOSURL` is provided in the DPFHCPProvisioner spec. |
| `spec.blueFieldOCPLayerRepo` | `string` | `quay.io/edge-infrastructure/bluefield-ocp` | Container registry repository for BlueField RHCOS OCP image layers. The operator queries this repo to find an image tag matching the OCP version. The lookup is skipped when `machineOSURL` is provided in the DPFHCPProvisioner spec. |

### Behavior

Expand Down
2 changes: 1 addition & 1 deletion helm/dpf-hcp-provisioner-operator/templates/dpfhcpprovisionerconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ metadata:
{{- toYaml . | nindent 4 }}
{{- end }}
spec:
blueFieldOCPLayerRepo: {{ .Values.provisionerConfig.blueFieldOCPLayerRepo | default "quay.io/eelgaev/rhcos-bfb" | quote }}
blueFieldOCPLayerRepo: {{ .Values.provisionerConfig.blueFieldOCPLayerRepo | default "quay.io/edge-infrastructure/bluefield-ocp" | quote }}
2 changes: 1 addition & 1 deletion test/e2e/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ make verify-files check-cluster create-vms prepare-manifests cluster-install upd
```bash
export KUBECONFIG=/path/to/kubeconfig
export IMAGE_DPF_HCP_PROVISIONER_OPERATOR_CI=quay.io/redhat-user-workloads/dpf-hcp-provisioner-tenant/dpf-hcp-provisioner:latest
export MACHINE_OS_URL=quay.io/eelgaev/rhcos-bfb:4.22.0-ec.2
export MACHINE_OS_URL=quay.io/edge-infrastructure/bluefield-ocp:4.21.9
export BASE_DOMAIN=your-cluster.example.com
make test-e2e
```
Expand Down