fix: Prevent "null" identifier collisions from malformed drink JSON

[Copilot]

Producer.fromJson and Product.fromJson were coercing nullable id/name fields with .toString(), which turned missing values into the literal "null". That allowed multiple bad records to share the same ID, causing key collisions in lists and incorrect ID-based lookups.

• Model parsing hardening (lib/models/drink.dart)

  • Replaced nullable .toString() coercion with nullable string casts + empty fallback:
    • id: (json['id'] as String?) ?? ''
    • name: (json['name'] as String?) ?? ''
  • Prevents accidental "null" string IDs/names.

• Repository-layer record filtering (lib/services/beer_api_service.dart)

  • In parseProducers, now skips:
    • producers with empty producer.id
    • products with empty product.id
  • Keeps invalid upstream records from entering app state and avoids downstream key/lookup corruption.

• Regression coverage

  • Added model tests for null id/name parsing to ''.
  • Added API parsing tests to verify products/producers with missing IDs are excluded.

return Product(
  id: (json['id'] as String?) ?? '',
  name: (json['name'] as String?) ?? '',
  // ...
);

// parseProducers
if (producer.id.isEmpty) continue;
for (final product in producer.products) {
  if (product.id.isEmpty) continue;
  drinks.add(Drink(product: product, producer: producer, festivalId: festivalId));
}

[Copilot]

Pull request overview

Hardens drink JSON parsing and downstream API parsing to prevent key collisions and incorrect lookups when upstream records have missing id/name fields (previously coerced into the literal "null").

Changes:

• Update Producer.fromJson / Product.fromJson to avoid .toString() on nullable id/name, mapping missing values to ''.
• Filter invalid records in BeerApiService.parseProducers by skipping producers/products with empty IDs.
• Add regression tests covering null ID/name parsing and API filtering behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
lib/models/drink.dart	Adjusts model JSON parsing for id/name to avoid "null" and reduce collisions.
lib/services/beer_api_service.dart	Skips producers/products with empty IDs when flattening to Drink list.
test/models_test.dart	Adds regression tests for null id/name mapping to ''.
test/beer_api_service_test.dart	Adds tests ensuring API parsing skips invalid producers/products missing IDs.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

🚀 Cloudflare Pages Preview

Your preview deployment is ready!

Preview URL: https://copilot-fix-missing-id-name.staging-cambeerfestival.pages.dev

This preview will be automatically updated when you push new commits to this PR.

[richardthe3rd]

@copilot fix pr lint failure

[Copilot]

@copilot fix pr lint failure

I checked the failing PR Lint run: it’s failing the semantic-title check, not code lint. Please rename the PR title to a Conventional Commits format, for example:

fix: prevent "null" identifier collisions from malformed drink JSON

After retitling, PR Lint should pass.