Skip to content

Conversation

@Seb-sti1
Copy link
Contributor

@Seb-sti1 Seb-sti1 commented Dec 5, 2024

As discussed in #39, #34 (comment) and #34 (comment) there is a new property in SceneInfo called paperSize according to the debug output of remarkable software

I changed the test_blocks_keep_unknown_data_in_main_block as suggested by the comment. As it is in hex and a bit hard to read, here is an explanation of the modification made :

hex signification modifications
2E000000 0000010D block definition 21 to 2E as the size of the SceneInfo is now 46 and not 33
1C 06000000 1F 0000 2F 0000 current_layer property None
2C 05000000 1F 0000 21 01 background_visible property None
3C 05000000 1F 0000 21 01 root_document_visible property None
5C 08000000 7C050000 50070000 (new) paper_size property Added as suggested by the comment
E1 FF new, unknown data None

I used the excess bytes 92, 8, 0, 0, 0, 124, 5, 0, 0, 80, 7, 0, 0 of #34 (comment)

Closes #39

@Seb-sti1 Seb-sti1 marked this pull request as draft December 5, 2024 15:52
@Azeirah
Copy link
Contributor

Azeirah commented Mar 16, 2025

@ricklupton @Seb-sti1 @ChenghaoMou Is there anything missing in here before this can be merged? I think it would be really nice to close the open PRs one by one. I can make time not this week, but the week after I'll have a sprint of two weeks to work on Scrybble, so I can take a look at all open PRs in rmscene and rmc?

Would be great to solve all the tiny lingering issues that are present currently, and especially to get proper color output at the end of the line.

@Seb-sti1
Copy link
Contributor Author

I don't believe there is anything missing on #41 #42 #45, they can be merged whenever it's possible :)

@ricklupton ricklupton merged commit 0fe5322 into ricklupton:main Mar 21, 2025
6 checks passed
@ricklupton
Copy link
Owner

Thanks for this @Seb-sti1, and @Azeirah for following up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse paperSize in SceneInfo

3 participants