Greatly simplify instruction decoding #2159
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
force-pushed
the
simplify-opcode-map
branch
from
11da3f0 to
e31ee2e
Compare
The opcode map was complex and fairly inefficient. Using a simple search is easier to understand and actually works faster in practice. Heuristically speeding up the search by occasionally resorting helps even further.
aswaterman
force-pushed
the
simplify-opcode-map
branch
from
e31ee2e to
36cf2d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opcode map was complex and fairly inefficient. Using a simple search is easier to understand and actually works faster in practice. Heuristically speeding up the search by occasionally resorting helps even further.