Fix VS-mode check for sireg* (really vsireg*) CSRs #2166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aswaterman
reviewed
Nov 30, 2025
Collaborator
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
I'm deferring review of this one to @mmhus, who contributed the code originally
Contributor
|
LGTM. I didn't check everything extensively for the 'H' extension previously. |
aswaterman
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From VS-mode to access sireg* (really vsireg*) will launch permission verification from 'virtualized_indirect_csr_t', instruction code's higher 12-bits should be with value 'sireg*' CSRs, then insn.csr() could not match CSR_VSIREG~CSR_VSIREG6